Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fix assignees double load bug #10856

Merged
merged 3 commits into from
Mar 28, 2020
Merged

bug: fix assignees double load bug #10856

merged 3 commits into from
Mar 28, 2020

Commits on Mar 28, 2020

  1. bug: fix assignees double load bug 

    Because the assigness has been loaded in

compare.go 416:
    RetrieveRepoMetas(ctx, ctx.Repo.Repository, true)
then
issue.go 381
	RetrieveRepoMilestonesAndAssignees(ctx, repo)
then

issue.go 361 -- 365 , they are load assignees

So the code on compare.go 425 -- 427 is double work,
and which is the reason of go-gitea#10853

Signed-off-by: a1012112796 <[email protected]>
    @a1012112796
    a1012112796 committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    f92002d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix_assignees

    @lafriks
    lafriks committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    ebb83ec View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix_assignees

    @zeripath
    zeripath committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    691639b View commit details
    Browse the repository at this point in the history