Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Users with only read rights can select assignees on new PR page #10853

Closed
7 tasks
a1012112796 opened this issue Mar 27, 2020 · 0 comments · Fixed by #10856
Closed
7 tasks

[bug] Users with only read rights can select assignees on new PR page #10853

a1012112796 opened this issue Mar 27, 2020 · 0 comments · Fixed by #10856
Labels
type/bug

Comments

@a1012112796
Copy link
Member

a1012112796 commented Mar 27, 2020 •
edited
Loading

  • Gitea version (or commit ref): mast , mabe v1.11.x is same
  • Git version:
  • Operating system:
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

there are a small bug about New PR page
user who don't have write permission can choose assignees on here:
jta
test on gitea.com
jtc
a1012112796 added a commit to a1012112796/gitea that referenced this issue Mar 28, 2020
@a1012112796
bug: fix assignees double load bug
f92002d 
Because the assigness has been loaded in

compare.go 416:
    RetrieveRepoMetas(ctx, ctx.Repo.Repository, true)
then
issue.go 381
	RetrieveRepoMilestonesAndAssignees(ctx, repo)
then

issue.go 361 -- 365 , they are load assignees

So the code on compare.go 425 -- 427 is double work,
and which is the reason of go-gitea#10853

Signed-off-by: a1012112796 <[email protected]>
@a1012112796 a1012112796 mentioned this issue Mar 28, 2020
Merged
@guillep2k guillep2k changed the title [bug]some small bug about New PR page [bug] Users with only read rights can select assignees on new PR page Mar 28, 2020
zeripath pushed a commit that referenced this issue Mar 28, 2020
@a1012112796
bug: fix assignees double load bug (#10856)
f9f2c16 
Because the assigness has been loaded in

compare.go 416:
    RetrieveRepoMetas(ctx, ctx.Repo.Repository, true)
then
issue.go 381
	RetrieveRepoMilestonesAndAssignees(ctx, repo)
then

issue.go 361 -- 365 , they are load assignees

So the code on compare.go 425 -- 427 is double work,
and which is the reason of #10853

Signed-off-by: a1012112796 <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug: fix assignees double load bug a1012112796/gitea
2 participants
@guillep2k @a1012112796