Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile page CSS #10406

Merged
merged 4 commits into from
Feb 22, 2020
Merged

Fix profile page CSS #10406

merged 4 commits into from
Feb 22, 2020

Conversation

jolheiser
Copy link
Member

Fixes #9980

Same as the usual fomantic changes, the styles were changed and no longer applied.
I chose the units based on a working version of Gitea and spying on the rendered styles on the page.

Somehow this style looks correct on my 1.11 instance (which is when fomantic was added)...so I'm not sure whether this needs a backport or not...

Screenshot from 2020-02-21 15-35-04

Signed-off-by: jolheiser <[email protected]>
Signed-off-by: jolheiser <[email protected]>
@jolheiser jolheiser added type/bug topic/ui Change the appearance of the Gitea UI labels Feb 21, 2020
@jolheiser jolheiser added this to the 1.12.0 milestone Feb 21, 2020
web_src/less/_user.less Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 21, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 21, 2020
@lunny
Copy link
Member

lunny commented Feb 22, 2020

CI failed.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 22, 2020
@codecov-io
Copy link

Codecov Report

Merging #10406 into master will decrease coverage by 0.1%.
The diff coverage is 15.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10406      +/-   ##
==========================================
- Coverage   43.79%   43.69%   -0.11%     
==========================================
  Files         586      586              
  Lines       81121    81351     +230     
==========================================
+ Hits        35529    35546      +17     
- Misses      41197    41405     +208     
- Partials     4395     4400       +5
Impacted Files Coverage Δ
routers/api/v1/repo/pull.go 34.82% <0%> (-0.36%) ⬇️
routers/repo/editor.go 26.09% <0%> (-0.66%) ⬇️
modules/git/tree_entry.go 59.86% <0%> (-13.47%) ⬇️
services/pull/merge.go 49.45% <0%> (-0.99%) ⬇️
modules/git/error.go 48% <0%> (-6.55%) ⬇️
routers/utils/utils.go 72% <0%> (-28%) ⬇️
models/error.go 29.49% <0%> (-1.46%) ⬇️
routers/repo/pull.go 28.61% <0%> (-0.09%) ⬇️
modules/repofiles/temp_repo.go 58.54% <13.63%> (-3.57%) ⬇️
routers/repo/view.go 36.75% <30.15%> (-3.17%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e65719...99c172d. Read the comment docs.

@lafriks lafriks merged commit f437063 into go-gitea:master Feb 22, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile CSS broken
6 participants