Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue sidebar menus having an infinite height #10239

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

jamesorlakin
Copy link
Contributor

@jamesorlakin jamesorlakin commented Feb 11, 2020

A partial revert of #10216, yet still an attempt at fixing #10218. This PR sets the max-height property to a different selector so it fixes the assignee menu too.

Before:
image

After:
image

I'm willing to create a backport for v1.11, as it is quite noticetable on my production instance! 😄

@jamesorlakin jamesorlakin changed the title Bugfix/long sidebar menu Fix issue sidebar menus having an infinite height Feb 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #10239 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10239      +/-   ##
==========================================
- Coverage   43.68%   43.67%   -0.02%     
==========================================
  Files         582      582              
  Lines       80048    80048              
==========================================
- Hits        34966    34957       -9     
- Misses      40747    40754       +7     
- Partials     4335     4337       +2
Impacted Files Coverage Δ
modules/indexer/stats/db.go 55.17% <0%> (-10.35%) ⬇️
services/pull/temp_repo.go 29.05% <0%> (-2.57%) ⬇️
services/pull/patch.go 60.37% <0%> (-2.52%) ⬇️
services/pull/check.go 32.92% <0%> (-2.44%) ⬇️
modules/queue/workerpool.go 50.17% <0%> (ø) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
modules/process/manager.go 78.31% <0%> (+3.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c7998...5d2add8. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 11, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 11, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Feb 11, 2020
@lafriks lafriks added this to the 1.12.0 milestone Feb 11, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 11, 2020
@lafriks lafriks merged commit 54af3c9 into go-gitea:master Feb 11, 2020
@lafriks
Copy link
Member

lafriks commented Feb 11, 2020

Please send backport

@jamesorlakin
Copy link
Contributor Author

Already done ;). I forgot to set the title properly though! #10240

@zeripath zeripath added the backport/done All backports for this PR have been created label Feb 15, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants