Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit label list height on edit issue page #10216

Merged
merged 2 commits into from
Feb 11, 2020
Merged

Limit label list height on edit issue page #10216

merged 2 commits into from
Feb 11, 2020

Conversation

jaqra
Copy link
Contributor

@jaqra jaqra commented Feb 10, 2020

Before was no limit:

Screenshot_2020-02-10_23-15-19

After:

Screenshot_2020-02-10_23-10-48

@codecov-io
Copy link

codecov-io commented Feb 10, 2020

Codecov Report

Merging #10216 into master will increase coverage by 0.03%.
The diff coverage is 50.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10216      +/-   ##
==========================================
+ Coverage   43.62%   43.66%   +0.03%     
==========================================
  Files         576      582       +6     
  Lines       79716    80045     +329     
==========================================
+ Hits        34778    34952     +174     
- Misses      40639    40757     +118     
- Partials     4299     4336      +37
Impacted Files Coverage Δ
routers/org/home.go 65.68% <ø> (-0.34%) ⬇️
models/migrations/migrations.go 4.16% <ø> (ø) ⬆️
routers/user/profile.go 50.46% <ø> (-0.24%) ⬇️
routers/init.go 63.04% <0%> (-2.13%) ⬇️
modules/notification/indexer/indexer.go 50.66% <0%> (-4.41%) ⬇️
models/migrations/v127.go 0% <0%> (ø)
modules/graceful/manager_unix.go 40.83% <0%> (ø) ⬆️
modules/git/repo_commit.go 53.39% <0%> (ø) ⬆️
models/models.go 61.93% <100%> (+0.21%) ⬆️
modules/indexer/code/bleve.go 66.07% <100%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f34a4c...d68b6d3. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 10, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Feb 10, 2020
@lafriks lafriks added this to the 1.12.0 milestone Feb 10, 2020
@jamesorlakin
Copy link
Contributor

This also happens on the assignees on 1.11.0. I assume it's the same behaviour for labels but we don't have many... I think this should be backported, I'm happy to make a PR.

@jaqra
Copy link
Contributor Author

jaqra commented Feb 11, 2020

as @proton-ab said i copied this rule from New Issue page

@lafriks marked as resolved. so i need to do anything?

@jamesorlakin ofcourse you can make a backport after merge :)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 11, 2020
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK to maintain the 300px value for consistency, but perhaps we should change them all to a relative height in a future PR.

This one LGTM 👍

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 11, 2020
@sapk sapk merged commit 602b29e into go-gitea:master Feb 11, 2020
@jamesorlakin
Copy link
Contributor

Having had a closer look while creating a backport, I'm not sure this will also fix a long assignments list as well. The extra CSS property is only assigned to the label selector, whereas the underlined selector is common between the two (_repository.less:91) and I feel should be changed instead.

image
(Names redacted because this is my work's 1.11 instance)

@jaqra
Copy link
Contributor Author

jaqra commented Feb 11, 2020

@jamesorlakin can you send a pr?

@jamesorlakin
Copy link
Contributor

Sure, I'll make a PR against master and then experiment with backporting it 👍

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet