Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commit view #10169

Merged
merged 4 commits into from
Feb 7, 2020
Merged

Fix commit view #10169

merged 4 commits into from
Feb 7, 2020

Conversation

jolheiser
Copy link
Member

I'm guessing it fixes #10163 and it was mis-reported, but I could be wrong.

Unsure about the effect on a11y, but visibility: hidden doesn't "reclaim" space and so effectively didn't do what collapse is intended for.

Signed-off-by: jolheiser <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 6, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Feb 6, 2020
@lafriks lafriks added this to the 1.12.0 milestone Feb 6, 2020
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, bug was introduced in #9968.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 6, 2020
@codecov-io
Copy link

codecov-io commented Feb 7, 2020

Codecov Report

Merging #10169 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10169      +/-   ##
==========================================
+ Coverage   43.41%   43.41%   +<.01%     
==========================================
  Files         576      576              
  Lines       79640    79642       +2     
==========================================
+ Hits        34572    34579       +7     
+ Misses      40791    40787       -4     
+ Partials     4277     4276       -1
Impacted Files Coverage Δ
modules/graceful/server.go 49.28% <100%> (+0.73%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
modules/process/manager.go 78.31% <0%> (+3.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb0e3c7...e61fdc0. Read the comment docs.

@lunny lunny merged commit cf33a18 into go-gitea:master Feb 7, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A Bug in Commit views
7 participants