fix commit view JS features, reimplement folding #9968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File content folding was not working so I reimplemented it in a saner way. Then I noticed the issue was actually because of missing JS libraries (seen on the console of every commit with error 'SimpleMDE is not defined'). Fixed the libraries. I think the reimplementation is worth to keep.
silverwind
commented
Jan 24, 2020
GiteaBot
added
the
lgtm/need 2
|
@silverwind you wouldn't be able to switch us to EasyMDE would you? I think simplemde is a bit dead... |
zeripath
approved these changes
Jan 24, 2020
GiteaBot
added
lgtm/need 1
Not sure if I'm motivated, SimpleMDE code is major spaghetti. |
Codecov Report
@@ Coverage Diff @@
## master #9968 +/- ##
==========================================
+ Coverage 42.24% 42.27% +0.03%
==========================================
Files 610 610
Lines 80276 80372 +96
==========================================
+ Hits 33909 33976 +67
- Misses 42204 42218 +14
- Partials 4163 4178 +15
Continue to review full report at Codecov.
|
lunny
approved these changes
Jan 26, 2020
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File content folding was not working so I reimplemented it in a saner way. Then I noticed the issue was actually because of missing JS libraries (seen on the console of every commit with error
'SimpleMDE is not defined') resulting in most JS on that page in not being executed.
Fixed the libraries. I think the reimplementation is worth to keep.
Example page with such an error: https://try.gitea.io/silverwind/symlink-test/commit/98701cd58e49972ff22203d217176f3ad27c235c