-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept punctuation after simple+cross repository issue references #10091
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10091 +/- ##
==========================================
- Coverage 43.48% 43.45% -0.03%
==========================================
Files 566 566
Lines 79024 79024
==========================================
- Hits 34366 34343 -23
- Misses 40421 40441 +20
- Partials 4237 4240 +3
Continue to review full report at Codecov.
|
i think it close #10074 |
And
|
No problem, I can add those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per above awaiting addition of ? and !
Added
This was not apparent in markdown rendering because the function takes them one by one. |
@lunny done. |
This PR adds
,
,;
and:
as valid characters following a simple issue or PR ref, as long as there's a spacing character following:Attempts to close (?) #10074, but I've left a few cases out; I feel a little uncomfortable trying to read too much out of the text with just a regexp, I don't want to start getting too many false positives:
Look at !1234!
) but it may work with issues (Look at #1234!
).AAAA-1234
) references.Fixes #10074