Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross reference doesn't render as a link if followed by punctuation signs (colon, semicolon, question, ...) #10074

Closed
1 of 7 tasks
InExtremaRes opened this issue Jan 30, 2020 · 3 comments · Fixed by #10091
Closed
1 of 7 tasks

Comments

@InExtremaRes
Copy link

InExtremaRes commented Jan 30, 2020

Description

When a message references another issue with #number syntax the reference doesn't show as a link if there is a colon, semicolon, question sign or others punctuation signs just after it. I didn't test more but I thinks these are very common and should be supported.

Screenshots

image

@InExtremaRes InExtremaRes changed the title Cross reference doesn't render as a link if followed by colon or semicolon Cross reference doesn't render as a link if followed by punctuation signs (colon, semicolon, question, ...) Jan 30, 2020
@guillep2k
Copy link
Member

For context, this was enabled for mentions (@user) in #8889, but there was no discussion about what characters are allowed following an issue or pr reference. It's tricky business because issue references can take a lot of shapes. For simple numeric references, currently only ), ], : and . are supported; the latter only if it's immediately followed by space or EOL. I think ; and , could follow the same rule as well.

@InExtremaRes
Copy link
Author

Yes, you're right that it's tricky. Support for ; and , with the same rules that : and . would be great.

Can ? and ! be supported as well? I think if the rule is the same (space or EOL immediately after) then it isn't ambiguous, but I can say nothing about the troubles to implement that.

@guillep2k
Copy link
Member

This can be closed as per #10091

@zeripath zeripath closed this as completed Feb 1, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants