Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add apple-touch-icon #10006

Merged
merged 3 commits into from
Jan 27, 2020
Merged

add apple-touch-icon #10006

merged 3 commits into from
Jan 27, 2020

Conversation

silverwind
Copy link
Member

favicon.png conveniently is already in the correct size.

Fixes: #10003

@zeripath
Copy link
Contributor

Can we add the precomposed thing for android whilst we're at it?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 26, 2020
@silverwind
Copy link
Member Author

I think Android requires a manifest.json, probably better to do that another time.

@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Jan 26, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone Jan 26, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 26, 2020
@codecov-io
Copy link

codecov-io commented Jan 26, 2020

Codecov Report

Merging #10006 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10006      +/-   ##
==========================================
+ Coverage   42.25%   42.27%   +0.01%     
==========================================
  Files         610      610              
  Lines       80372    80372              
==========================================
+ Hits        33965    33976      +11     
+ Misses      42230    42218      -12     
- Partials     4177     4178       +1
Impacted Files Coverage Δ
modules/options/options.go 96.15% <ø> (ø) ⬆️
modules/public/public.go 74.41% <ø> (ø) ⬆️
models/pull_sign.go 34.86% <0%> (ø) ⬆️
models/repo_sign.go 36.2% <0%> (ø) ⬆️
modules/avatar/avatar.go 48% <0%> (-6%) ⬇️
routers/repo/view.go 39.47% <0%> (+0.87%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
services/pull/patch.go 69.81% <0%> (+1.88%) ⬆️
models/unit.go 39.5% <0%> (+2.46%) ⬆️
services/pull/temp_repo.go 34.18% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe3832...a082620. Read the comment docs.

@zeripath
Copy link
Contributor

Not according to the link I put on the issue... but if you're sure.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 26, 2020
@silverwind
Copy link
Member Author

silverwind commented Jan 26, 2020

Yeah, that Android advice seems strange, I would not implement it like that. I think Android mostly just uses our existing shortcut icon.

If we want to support add-to-homescreen on Android, we should do https://developers.google.com/web/fundamentals/web-app-manifest, but I don't see much need for that as Gitea hardly qualifies as an "app".

@lunny lunny merged commit 03cb168 into go-gitea:master Jan 27, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add a touch icon.
7 participants