Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Add a touch icon. #10003

Closed
NiTRoeSE opened this issue Jan 26, 2020 · 3 comments · Fixed by #10006
Closed

[Enhancement] Add a touch icon. #10003

NiTRoeSE opened this issue Jan 26, 2020 · 3 comments · Fixed by #10006
Labels
topic/ui Change the appearance of the Gitea UI type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Comments

@NiTRoeSE
Copy link
Contributor

Please add a "apple touch Icon".
If you add gitea website as app to homscreen on ios devices there is no icon shown because of missing touch icon.

Sample:

IMG_0322

Should be:

IMG_0323

It would be nice and of course gitea has it deserved that also a proper icon is displayed :)

Thanks for your work, Gitea is great :)
@zeripath
Copy link
Contributor

For anyone interested in providing a PR for this.

https://www.collectiveray.com/joomla/joomla-tips-and-tricks/94-creating-a-favicon-and-apple-icon-for-your-website.html

seems to describe how to do it...

@zeripath zeripath added topic/ui Change the appearance of the Gitea UI type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Jan 26, 2020
@silverwind
Copy link
Member

Assuming https://realfavicongenerator.net is up to date, it should be one 180px icon:

<link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png">

We can add it to https://github.com/go-gitea/gitea/blob/master/Makefile#L516

@silverwind silverwind mentioned this issue Jan 26, 2020
Merged
silverwind added a commit to silverwind/gitea that referenced this issue Jan 26, 2020
@silverwind
add apple-touch-icon
2fe2021 
fixes: go-gitea#10003
@NiTRoeSE
Copy link
Contributor Author

@silverwind / @zeripath

Thanks guys for fast reply and commit. 😀

lunny added a commit that referenced this issue Jan 27, 2020
@silverwind @zeripath @lunny
add apple-touch-icon (#10006)
03cb168 
fixes: #10003

Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add apple-touch-icon silverwind/gitea
3 participants
@silverwind @zeripath @NiTRoeSE