Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reached MAX_CREATION_LIMIT forbids user from creating a repo within an org #9269

Closed
2 of 7 tasks
fpiecka opened this issue Dec 6, 2019 · 5 comments · Fixed by #11183
Closed
2 of 7 tasks

Reached MAX_CREATION_LIMIT forbids user from creating a repo within an org #9269

fpiecka opened this issue Dec 6, 2019 · 5 comments · Fixed by #11183
Labels

Comments

@fpiecka
Copy link

fpiecka commented Dec 6, 2019

  • Gitea version (or commit ref): 1.9.5
  • Operating system: Debian 9
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant

Description

A user which has reached MAX_CREATION_LIMIT cannot create a repository in an organization where (s)he is an owner.

However when user's MAX_CREATION_LIMIT isn't reached, (s)he can create any number of repositories in an organization. These repositories aren't counted toward the user's MAX_CREATION_LIMIT, which I consider correct. I believe there should be no restriction based on user's MAX_CREATION_LIMIT state for organization owned repos.

...

Screenshots

@lunny lunny added the type/bug label Dec 8, 2019
@fpiecka
Copy link
Author

fpiecka commented Dec 11, 2019

It seems the problem is only with web UI. Repos belonging to organizations can be reated using API even when user's MAX_CREATION_LIMIT is reached.

@AndrewBezold
Copy link
Contributor

AndrewBezold commented Jan 10, 2020

Using the master branch from a few days ago, I hit the same issue through the api (user has reached the maximum limit of repositories), so it's not just a web client issue.

EDIT: Nevermind, orgs have a maximum limit as well, disregard

@stale
Copy link

stale bot commented Mar 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Mar 11, 2020
@fpiecka
Copy link
Author

fpiecka commented Mar 24, 2020

The issue is still present, please keep it open (even better, fix it:) ).

@stale stale bot removed the issue/stale label Mar 24, 2020
@stale
Copy link

stale bot commented Apr 7, 2020

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Apr 7, 2020
@zeripath zeripath reopened this Apr 7, 2020
AndrewBezold added a commit to AndrewBezold/gitea that referenced this issue Apr 23, 2020
zeripath pushed a commit that referenced this issue Apr 30, 2020
… repos (#11183)

* Fix creation of Org repos

Fix #9269

* Change variable name to appease linter

* Update PR with suggestions

Add a note for user.CanCreateRepo() about failure assumptions
Change repo.create help message

Co-authored-by: guillep2k <[email protected]>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
… repos (go-gitea#11183)

* Fix creation of Org repos

Fix go-gitea#9269

* Change variable name to appease linter

* Update PR with suggestions

Add a note for user.CanCreateRepo() about failure assumptions
Change repo.create help message

Co-authored-by: guillep2k <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants