Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI loading google fonts for lato #11243

Closed
daniubi opened this issue Apr 29, 2020 · 8 comments · Fixed by #11244
Closed

UI loading google fonts for lato #11243

daniubi opened this issue Apr 29, 2020 · 8 comments · Fixed by #11244
Labels
topic/ui Change the appearance of the Gitea UI

Comments

@daniubi
Copy link

daniubi commented Apr 29, 2020

jquery.js load error

https://fonts.googleapis.com/css?family=Lato:400,700,400italic,700italic&subset=latin&display=swap

wait 55s very slow
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Apr 29, 2020
@techknowlogick
Copy link
Member

related fomantic/Fomantic-UI#367 and fomantic/Fomantic-UI#373

@techknowlogick techknowlogick changed the title gitea in not the Internet UI loading google fonts for lato Apr 29, 2020
@daniubi
Copy link
Author

daniubi commented Apr 29, 2020

if we don't have the internet,there is a problem.

@alexanderadam
Copy link

alexanderadam commented Apr 29, 2020 •
edited
Loading

if we don't have the internet,there is a problem.

This is clear but it relies on the mentioned fomatic issue, nevertheless.
You can override the font manually if you don't want to wait until the fomatic issue is solved.

@lunny shouldn't have your PR make this configurable easier?

@lunny
Copy link
Member

lunny commented Apr 29, 2020

@alexanderadam I think yes but haven't spent time to investigate how to instead it.

@silverwind
Copy link
Member

I think we already fixed this here but because of #10655, semantic.css is currently not being custom-built but instead copied.

Still waiting on the next Fomantic UI release for fomantic/Fomantic-UI@6f8dc82. Maybe we should consider patching Fomantic-UI after installation using patch-package or similar.

@6543
Copy link
Member

6543 commented Apr 29, 2020

best way would still be to have it fixed upstream

silverwind added a commit to silverwind/gitea that referenced this issue Apr 29, 2020
@silverwind
Patch fomantic-ui to workaround build issue
f3eb8a6 
Better workaround than go-gitea#10653
for fomantic/Fomantic-UI#1356. It does not
seem like we're getting a new Fomantic-UI release anytime soon, so
this patches it after node_modules installation.

Fixes: go-gitea#11243
Fixes: go-gitea#10679
@silverwind silverwind mentioned this issue Apr 29, 2020
Merged
@silverwind
Copy link
Member

It is fixed upstream, but just not released yet.

@daniubi
Copy link
Author

daniubi commented Apr 30, 2020

thanks

zeripath added a commit that referenced this issue Apr 30, 2020
@silverwind @Sorien
@zeripath @lunny @guillep2k
Patch fomantic-ui to workaround build issue (#11244)
310699b 
* Patch fomantic-ui to workaround build issue

Better workaround than #10653
for fomantic/Fomantic-UI#1356. It does not
seem like we're getting a new Fomantic-UI release anytime soon, so
this patches it after node_modules installation.

Fixes: #11243
Fixes: #10679

* copy instead of patch

* update package-lock.json

* Update Makefile

Co-Authored-By: Sorien <[email protected]>

* Update web_src/fomantic/css.js

Co-Authored-By: zeripath <[email protected]>

Co-authored-by: Sorien <[email protected]>
Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: guillep2k <[email protected]>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@silverwind @Sorien
@zeripath @lunny @guillep2k
Patch fomantic-ui to workaround build issue (go-gitea#11244)
04619d2 
* Patch fomantic-ui to workaround build issue

Better workaround than go-gitea#10653
for fomantic/Fomantic-UI#1356. It does not
seem like we're getting a new Fomantic-UI release anytime soon, so
this patches it after node_modules installation.

Fixes: go-gitea#11243
Fixes: go-gitea#10679

* copy instead of patch

* update package-lock.json

* Update Makefile

Co-Authored-By: Sorien <[email protected]>

* Update web_src/fomantic/css.js

Co-Authored-By: zeripath <[email protected]>

Co-authored-by: Sorien <[email protected]>
Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: guillep2k <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patch fomantic-ui to workaround build issue silverwind/gitea
6 participants
@lunny @silverwind @techknowlogick @alexanderadam @6543 @daniubi