Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offline mode still trying to load css from googleapis #10679

Closed
2 of 4 tasks
zsxsoft opened this issue Mar 9, 2020 · 1 comment · Fixed by #11244
Closed
2 of 4 tasks

Offline mode still trying to load css from googleapis #10679

zsxsoft opened this issue Mar 9, 2020 · 1 comment · Fixed by #11244

Comments

@zsxsoft
Copy link

zsxsoft commented Mar 9, 2020 •
edited

  • Gitea version (or commit ref): 1.12.0+dev-2-g3fc4f3670
  • Git version:
  • Operating system: Arch Linux
  • Database (use [x]):
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes
    • No
    • Not relevant
  • Log gist:

Description

This is NOT a duplicate of #4871

This semantic.min.css will still load fonts from googleapis in offline modes:
https://try.gitea.io/fomantic/semantic.min.css?v=6598fed08fd8c85879b3e60fbb9a81b3

And I found lots of googleapis in CodeMirror plugin: https://github.com/go-gitea/gitea/search?q=googleapis&type=
@silverwind
Copy link
Member

This is a consequence of the workaround for #10653. We have to wait until next Fomantic UI release.

silverwind added a commit to silverwind/gitea that referenced this issue Apr 29, 2020
@silverwind
Patch fomantic-ui to workaround build issue
f3eb8a6 
Better workaround than go-gitea#10653
for fomantic/Fomantic-UI#1356. It does not
seem like we're getting a new Fomantic-UI release anytime soon, so
this patches it after node_modules installation.

Fixes: go-gitea#11243
Fixes: go-gitea#10679
@silverwind silverwind mentioned this issue Apr 29, 2020
Merged
zeripath added a commit that referenced this issue Apr 30, 2020
@silverwind @Sorien
@zeripath @lunny @guillep2k
Patch fomantic-ui to workaround build issue (#11244)
310699b 
* Patch fomantic-ui to workaround build issue

Better workaround than #10653
for fomantic/Fomantic-UI#1356. It does not
seem like we're getting a new Fomantic-UI release anytime soon, so
this patches it after node_modules installation.

Fixes: #11243
Fixes: #10679

* copy instead of patch

* update package-lock.json

* Update Makefile

Co-Authored-By: Sorien <[email protected]>

* Update web_src/fomantic/css.js

Co-Authored-By: zeripath <[email protected]>

Co-authored-by: Sorien <[email protected]>
Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: guillep2k <[email protected]>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@silverwind @Sorien
@zeripath @lunny @guillep2k
Patch fomantic-ui to workaround build issue (go-gitea#11244)
04619d2 
* Patch fomantic-ui to workaround build issue

Better workaround than go-gitea#10653
for fomantic/Fomantic-UI#1356. It does not
seem like we're getting a new Fomantic-UI release anytime soon, so
this patches it after node_modules installation.

Fixes: go-gitea#11243
Fixes: go-gitea#10679

* copy instead of patch

* update package-lock.json

* Update Makefile

Co-Authored-By: Sorien <[email protected]>

* Update web_src/fomantic/css.js

Co-Authored-By: zeripath <[email protected]>

Co-authored-by: Sorien <[email protected]>
Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: guillep2k <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patch fomantic-ui to workaround build issue silverwind/gitea
2 participants
@silverwind @zsxsoft