Skip to content

Commit

Permalink
bug: fix assignees double load bug (#10856)
Browse files Browse the repository at this point in the history
Because the assigness has been loaded in

compare.go 416:
    RetrieveRepoMetas(ctx, ctx.Repo.Repository, true)
then
issue.go 381
	RetrieveRepoMilestonesAndAssignees(ctx, repo)
then

issue.go 361 -- 365 , they are load assignees

So the code on compare.go 425 -- 427 is double work,
and which is the reason of #10853

Signed-off-by: a1012112796 <[email protected]>
  • Loading branch information
a1012112796 committed Mar 28, 2020
1 parent 828a27f commit f9f2c16
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions routers/repo/compare.go
Original file line number Diff line number Diff line change
Expand Up @@ -422,10 +422,6 @@ func CompareDiff(ctx *context.Context) {
beforeCommitID := ctx.Data["BeforeCommitID"].(string)
afterCommitID := ctx.Data["AfterCommitID"].(string)

if ctx.Data["Assignees"], err = ctx.Repo.Repository.GetAssignees(); err != nil {
ctx.ServerError("GetAssignees", err)
return
}

ctx.Data["Title"] = "Comparing " + base.ShortSha(beforeCommitID) + "..." + base.ShortSha(afterCommitID)

Expand Down

0 comments on commit f9f2c16

Please sign in to comment.