Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby: delete the target/packs folder in the compile-queries job #11358

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Ruby: delete the target/packs folder in the compile-queries job #11358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
delete packs
  • Loading branch information
@erik-krogh
erik-krogh committed Nov 21, 2022
commit 29055f770904c543a933fa8cbbffe2f2e8dc3763
1 change: 1 addition & 0 deletions .github/workflows/ruby-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ jobs:
key: ruby-build
- name: Build Query Pack
run: |
rm -rf target/packs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but how did this folder end up in the cache?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there was a .cache folder deep inside.
That .cache folder is actually the one we want to restore, but if it had stayed in the previous location (the 0.4.4-dev folder), then we wouldn't be able to use it.
So that's another reason to use the --compilation-dir option.

(The cache was saved when the Ruby analysis was version 0.4.4-dev, and restored on version 0.4.5-dev).

codeql pack create ../shared/ssa --output target/packs
codeql pack create ../misc/suite-helpers --output target/packs
codeql pack create ../shared/regex --output target/packs
Expand Down