Ruby: delete the target/packs folder in the compile-queries job
#11358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
approved these changes
Nov 22, 2022
| @@ -98,6 +98,7 @@ jobs: | |||
| key: ruby-build | |||
| - name: Build Query Pack | |||
| run: | | |||
| rm -rf target/packs | |||
There was a problem hiding this comment.
Looks good to me, but how did this folder end up in the cache?
There was a problem hiding this comment.
Because there was a .cache folder deep inside.
That .cache folder is actually the one we want to restore, but if it had stayed in the previous location (the 0.4.4-dev folder), then we wouldn't be able to use it.
So that's another reason to use the --compilation-dir option.
(The cache was saved when the Ruby analysis was version 0.4.4-dev, and restored on version 0.4.5-dev).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restoring the
.cachefolders meant that some oldtargetfolders was restored (specifically the0.4.4-devfolder).Even though there are no files in there (my cache job cleans them up), the folders are still there, and are picked up by
PACK_FOLDER=$(readlink -f target/packs/codeql/ruby-queries/*)in thecompile-queriesjob.The fix is simple: delete the entire
target/packsfolder.There is nothing but empty folders anyway.
Example failing workflow: https://github.com/github/codeql/actions/runs/3518802552/jobs/5898153387
Found when testing the improved workflow in this PR: #10782
(I also got the fix in that PR).