Output information after CMake configuration and generation. #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratikvn
added
is:enhancement
pratikvn
requested review from
upsj,
thoasm,
yhmtsai,
hartwiganzt,
tcojean and
fritzgoebel
upsj
reviewed
Aug 2, 2020
cmake/get_info.cmake
Outdated
| FILE(APPEND ${minimal_log} "${ARGN}") | ||
| ENDMACRO() | ||
|
|
||
| FUNCTION(build_type_spec log_type var_name) |
There was a problem hiding this comment.
question: Do we want to deal with other build types (sanitizers)?
There was a problem hiding this comment.
Regarding this, I am guessing you mean printing out a log when sanitizers are being built. I see this as some quick information for the user when they configure Ginkgo. I am not sure how many actually want to run Ginkgo with sanitizers.
There was a problem hiding this comment.
Fair point, I would only like to avoid anything breaking when we build other build types ;)
Codecov Report
@@ Coverage Diff @@
## develop #610 +/- ##
===========================================
- Coverage 93.02% 93.01% -0.01%
===========================================
Files 296 296
Lines 20656 20656
===========================================
- Hits 19215 19214 -1
- Misses 1441 1442 +1
Continue to review full report at Codecov.
|
yhmtsai
previously requested changes
Aug 3, 2020
upsj
reviewed
Aug 3, 2020
tcojean
reviewed
Aug 3, 2020
pratikvn
added
1:ST:WIP
pratikvn
added
1:ST:ready-for-review
upsj
approved these changes
Aug 6, 2020
pratikvn
force-pushed
the
cmake-summary
branch
2 times, most recently
from
cc74b50
to
3605227
Compare
tcojean
approved these changes
Aug 7, 2020
|
About the whole "unspecified" thing, this doesn't seem to work with all variables (See HIP), maybe some stray spaces in there? |
yhmtsai
approved these changes
Aug 7, 2020
|
I would even suggest replacing |
yhmtsai
reviewed
Aug 7, 2020
| string(SUBSTRING | ||
| " | ||
| -- ${var_name}: " 0 55 upd_string) | ||
| if(${var_name} STREQUAL "") |
There was a problem hiding this comment.
does it need to be "${${var_name}}"?
There was a problem hiding this comment.
I believe this should be correct, see Variable Expansion
pratikvn
commented
Aug 7, 2020
pratikvn
commented
Aug 7, 2020
pratikvn
commented
Aug 7, 2020
pratikvn
commented
Aug 7, 2020
This was because of some internal variables and hence they were empty. I dont think these are necessary anyway, so i removed them. |
tcojean
reviewed
Aug 7, 2020
+ Update CI jobs to display the detailed logs.
Co-authored-by: Terry Cojean <[email protected]> Co-authored-by: Tobias Ribizel <[email protected]> Co-authored-by: Yuhsiang M. Tsai <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
tcojean
added a commit
that referenced
this pull request
Aug 26, 2020
Release 1.3.0 of Ginkgo. The Ginkgo team is proud to announce the new minor release of Ginkgo version 1.3.0. This release brings CUDA 11 support, changes the default C++ standard to be C++14 instead of C++11, adds a new Diagonal matrix format and capacity for diagonal extraction, significantly improves the CMake configuration output format, adds the Ginkgo paper which got accepted into the Journal of Open Source Software (JOSS), and fixes multiple issues. Supported systems and requirements: + For all platforms, cmake 3.9+ + Linux and MacOS + gcc: 5.3+, 6.3+, 7.3+, all versions after 8.1+ + clang: 3.9+ + Intel compiler: 2017+ + Apple LLVM: 8.0+ + CUDA module: CUDA 9.0+ + HIP module: ROCm 2.8+ + Windows + MinGW and Cygwin: gcc 5.3+, 6.3+, 7.3+, all versions after 8.1+ + Microsoft Visual Studio: VS 2017 15.7+ + CUDA module: CUDA 9.0+, Microsoft Visual Studio + OpenMP module: MinGW or Cygwin. The current known issues can be found in the [known issues page](https://github.com/ginkgo-project/ginkgo/wiki/Known-Issues). Additions: + Add paper for Journal of Open Source Software (JOSS). [#479](#479) + Add a DiagonalExtractable interface. [#563](#563) + Add a new diagonal Matrix Format. [#580](#580) + Add Cuda11 support. [#603](#603) + Add information output after CMake configuration. [#610](#610) + Add a new preconditioner export example. [#595](#595) + Add a new cuda-memcheck CI job. [#592](#592) Changes: + Use unified memory in CUDA debug builds. [#621](#621) + Improve `BENCHMARKING.md` with more detailed info. [#619](#619) + Use C++14 standard instead of C++11. [#611](#611) + Update the Ampere sm information and CudaArchitectureSelector. [#588](#588) Fixes: + Fix documentation warnings and errors. [#624](#624) + Fix warnings for diagonal matrix format. [#622](#622) + Fix criterion factory parameters in CUDA. [#586](#586) + Fix the norm-type in the examples. [#612](#612) + Fix the WAW race in OpenMP is_sorted_by_column_index. [#617](#617) + Fix the example's exec_map by creating the executor only if requested. [#602](#602) + Fix some CMake warnings. [#614](#614) + Fix Windows building documentation. [#601](#601) + Warn when CXX and CUDA host compiler do not match. [#607](#607) + Fix reduce_add, prefix_sum, and doc-build. [#593](#593) + Fix find_library(cublas) issue on machines installing multiple cuda. [#591](#591) + Fix allocator in sellp read. [#589](#589) + Fix the CAS with HIP and NVIDIA backends. [#585](#585) Deletions: + Remove unused preconditioner parameter in LowerTrs. [#587](#587) Related PR: #625
tcojean
added a commit
that referenced
this pull request
Aug 27, 2020
The Ginkgo team is proud to announce the new minor release of Ginkgo version 1.3.0. This release brings CUDA 11 support, changes the default C++ standard to be C++14 instead of C++11, adds a new Diagonal matrix format and capacity for diagonal extraction, significantly improves the CMake configuration output format, adds the Ginkgo paper which got accepted into the Journal of Open Source Software (JOSS), and fixes multiple issues. Supported systems and requirements: + For all platforms, cmake 3.9+ + Linux and MacOS + gcc: 5.3+, 6.3+, 7.3+, all versions after 8.1+ + clang: 3.9+ + Intel compiler: 2017+ + Apple LLVM: 8.0+ + CUDA module: CUDA 9.0+ + HIP module: ROCm 2.8+ + Windows + MinGW and Cygwin: gcc 5.3+, 6.3+, 7.3+, all versions after 8.1+ + Microsoft Visual Studio: VS 2017 15.7+ + CUDA module: CUDA 9.0+, Microsoft Visual Studio + OpenMP module: MinGW or Cygwin. The current known issues can be found in the [known issues page](https://github.com/ginkgo-project/ginkgo/wiki/Known-Issues). Additions: + Add paper for Journal of Open Source Software (JOSS). [#479](#479) + Add a DiagonalExtractable interface. [#563](#563) + Add a new diagonal Matrix Format. [#580](#580) + Add Cuda11 support. [#603](#603) + Add information output after CMake configuration. [#610](#610) + Add a new preconditioner export example. [#595](#595) + Add a new cuda-memcheck CI job. [#592](#592) Changes: + Use unified memory in CUDA debug builds. [#621](#621) + Improve `BENCHMARKING.md` with more detailed info. [#619](#619) + Use C++14 standard instead of C++11. [#611](#611) + Update the Ampere sm information and CudaArchitectureSelector. [#588](#588) Fixes: + Fix documentation warnings and errors. [#624](#624) + Fix warnings for diagonal matrix format. [#622](#622) + Fix criterion factory parameters in CUDA. [#586](#586) + Fix the norm-type in the examples. [#612](#612) + Fix the WAW race in OpenMP is_sorted_by_column_index. [#617](#617) + Fix the example's exec_map by creating the executor only if requested. [#602](#602) + Fix some CMake warnings. [#614](#614) + Fix Windows building documentation. [#601](#601) + Warn when CXX and CUDA host compiler do not match. [#607](#607) + Fix reduce_add, prefix_sum, and doc-build. [#593](#593) + Fix find_library(cublas) issue on machines installing multiple cuda. [#591](#591) + Fix allocator in sellp read. [#589](#589) + Fix the CAS with HIP and NVIDIA backends. [#585](#585) Deletions: + Remove unused preconditioner parameter in LowerTrs. [#587](#587) Related PR: #627
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some outputs some information to the screen after CMake configuration to help the user see what configuration options have been selected. Essentially, it is a curated list of the CMakeCache.txt file.
There are two options: one being a minimal output enabled by default and the other is a detailed log which can be configured with
GINKGO_CONFIG_LOG_VERBOSITYflag. Both are written to a file in theCMAKE_BINARY_DIRin any case inminimal.loganddetailed.logrespectively.Additionally, the CI jobs will output the detailed log .
Closes #608 .