Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when CXX and CUDA host compiler do not match. #607

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Warn when CXX and CUDA host compiler do not match. #607

merged 1 commit into from
Aug 3, 2020

Conversation

tcojean
Copy link
Member

@tcojean tcojean commented Jul 31, 2020

On some systems, this can cause problems if the two compilers are tied
to different glib versions. At linking time (esp. for examples or
tests), it is then possible that some symbols are not found.

Closes #605

@tcojean tcojean added reg:build This is related to the build system. 1:ST:ready-for-review This PR is ready for review labels Jul 31, 2020
@tcojean tcojean self-assigned this Jul 31, 2020
upsj
upsj reviewed Jul 31, 2020
View reviewed changes
Copy link
Member

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work if CUDA_HOST_COMPILER is not defined? We only set it near the end of the file.

@thoasm
Copy link
Member

thoasm commented Jul 31, 2020

@upsj is correct, if CUDA_HOST_COMPILER is not set manually, it is not available here. I get the following output if I specify nothing (while setting CXX=gcc-10 during cmake):

  The CXX compiler is /usr/local/bin/gcc-10 with version 10.2.1.

  The CUDA host compiler is .

@tcojean
Copy link
Member Author

tcojean commented Jul 31, 2020

Interesting, thanks for the info. I had not checked without passing the variable as my system requires this.

@tcojean tcojean force-pushed the warn_mismatching_cxx_cuda_host branch from ec9af73 to 8dd584c Compare July 31, 2020 08:37
@tcojean
Warn when CXX and CUDA host compiler do not match.
84293f6 
On some systems, this can cause problems if the two compilers are tied
to different glib versions. At linking time (esp. for examples or
tests), it is then possible that some symbols are not found.
@tcojean tcojean force-pushed the warn_mismatching_cxx_cuda_host branch from 8dd584c to 84293f6 Compare July 31, 2020 08:58
@tcojean
Copy link
Member Author

tcojean commented Jul 31, 2020

I cannot really find a way to identify which compiler nvcc will use by default, so if for some reason it is not set (at least when setting GINKGO_CUDA_DEFAULT_HOST_COMPILER) then I do not print anything.

upsj
upsj approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

thoasm
thoasm approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@thoasm thoasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I could not find a way to get the cuda host compiler either.
Having this is definitively better than not having.

@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_121) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@tcojean
Copy link
Member Author

tcojean commented Jul 31, 2020

@thoasm

I could not find a way to get the cuda host compiler either.
Having this is definitively better than not having.

For reference, I found that you can find the host compiler by compiling some source code with nvcc and using the flag --verbose. Though it doesn't seem practical to extract the host compiler information from there (you need ot recognize the host compilation line, extract the command out of it, etc...).

@codecov
Copy link

codecov bot commented Aug 1, 2020

Codecov Report

Merging #607 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #607   +/-   ##
========================================
  Coverage    84.16%   84.16%           
========================================
  Files          296      296           
  Lines        20656    20656           
========================================
  Hits         17385    17385           
  Misses        3271     3271

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e0ff5...84293f6. Read the comment docs.

@tcojean tcojean added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Aug 3, 2020
@tcojean tcojean merged commit 094a426 into develop Aug 3, 2020
@tcojean tcojean deleted the warn_mismatching_cxx_cuda_host branch August 3, 2020 08:08
tcojean added a commit that referenced this pull request Aug 26, 2020
@tcojean
Merge Release 1.3.0 for develop
2c3e48d 
Release 1.3.0 of Ginkgo.

The Ginkgo team is proud to announce the new minor release of Ginkgo version
1.3.0. This release brings CUDA 11 support, changes the default C++ standard to
be C++14 instead of C++11, adds a new Diagonal matrix format and capacity for
diagonal extraction, significantly improves the CMake configuration output
format, adds the Ginkgo paper which got accepted into the Journal of Open Source
Software (JOSS), and fixes multiple issues.

Supported systems and requirements:
+ For all platforms, cmake 3.9+
+ Linux and MacOS
  + gcc: 5.3+, 6.3+, 7.3+, all versions after 8.1+
  + clang: 3.9+
  + Intel compiler: 2017+
  + Apple LLVM: 8.0+
  + CUDA module: CUDA 9.0+
  + HIP module: ROCm 2.8+
+ Windows
  + MinGW and Cygwin: gcc 5.3+, 6.3+, 7.3+, all versions after 8.1+
  + Microsoft Visual Studio: VS 2017 15.7+
  + CUDA module: CUDA 9.0+, Microsoft Visual Studio
  + OpenMP module: MinGW or Cygwin.


The current known issues can be found in the [known issues page](https://github.com/ginkgo-project/ginkgo/wiki/Known-Issues).


Additions:
+ Add paper for Journal of Open Source Software (JOSS). [#479](#479)
+ Add a DiagonalExtractable interface. [#563](#563)
+ Add a new diagonal Matrix Format. [#580](#580)
+ Add Cuda11 support. [#603](#603)
+ Add information output after CMake configuration. [#610](#610)
+ Add a new preconditioner export example. [#595](#595)
+ Add a new cuda-memcheck CI job. [#592](#592)

Changes:
+ Use unified memory in CUDA debug builds. [#621](#621)
+ Improve `BENCHMARKING.md` with more detailed info. [#619](#619)
+ Use C++14 standard instead of C++11. [#611](#611)
+ Update the Ampere sm information and CudaArchitectureSelector. [#588](#588)

Fixes:
+ Fix documentation warnings and errors. [#624](#624)
+ Fix warnings for diagonal matrix format. [#622](#622)
+ Fix criterion factory parameters in CUDA. [#586](#586)
+ Fix the norm-type in the examples. [#612](#612)
+ Fix the WAW race in OpenMP is_sorted_by_column_index. [#617](#617)
+ Fix the example's exec_map by creating the executor only if requested. [#602](#602)
+ Fix some CMake warnings. [#614](#614)
+ Fix Windows building documentation. [#601](#601)
+ Warn when CXX and CUDA host compiler do not match. [#607](#607)
+ Fix reduce_add, prefix_sum, and doc-build. [#593](#593)
+ Fix find_library(cublas) issue on machines installing multiple cuda. [#591](#591)
+ Fix allocator in sellp read. [#589](#589)
+ Fix the CAS with HIP and NVIDIA backends. [#585](#585)

Deletions:
+ Remove unused preconditioner parameter in LowerTrs. [#587](#587)

Related PR: #625
tcojean added a commit that referenced this pull request Aug 27, 2020
@tcojean
Merge Release 1.3.0 for master
4678668 
The Ginkgo team is proud to announce the new minor release of Ginkgo version
1.3.0. This release brings CUDA 11 support, changes the default C++ standard to
be C++14 instead of C++11, adds a new Diagonal matrix format and capacity for
diagonal extraction, significantly improves the CMake configuration output
format, adds the Ginkgo paper which got accepted into the Journal of Open Source
Software (JOSS), and fixes multiple issues.

Supported systems and requirements:
+ For all platforms, cmake 3.9+
+ Linux and MacOS
  + gcc: 5.3+, 6.3+, 7.3+, all versions after 8.1+
  + clang: 3.9+
  + Intel compiler: 2017+
  + Apple LLVM: 8.0+
  + CUDA module: CUDA 9.0+
  + HIP module: ROCm 2.8+
+ Windows
  + MinGW and Cygwin: gcc 5.3+, 6.3+, 7.3+, all versions after 8.1+
  + Microsoft Visual Studio: VS 2017 15.7+
  + CUDA module: CUDA 9.0+, Microsoft Visual Studio
  + OpenMP module: MinGW or Cygwin.


The current known issues can be found in the [known issues page](https://github.com/ginkgo-project/ginkgo/wiki/Known-Issues).


Additions:
+ Add paper for Journal of Open Source Software (JOSS). [#479](#479)
+ Add a DiagonalExtractable interface. [#563](#563)
+ Add a new diagonal Matrix Format. [#580](#580)
+ Add Cuda11 support. [#603](#603)
+ Add information output after CMake configuration. [#610](#610)
+ Add a new preconditioner export example. [#595](#595)
+ Add a new cuda-memcheck CI job. [#592](#592)

Changes:
+ Use unified memory in CUDA debug builds. [#621](#621)
+ Improve `BENCHMARKING.md` with more detailed info. [#619](#619)
+ Use C++14 standard instead of C++11. [#611](#611)
+ Update the Ampere sm information and CudaArchitectureSelector. [#588](#588)

Fixes:
+ Fix documentation warnings and errors. [#624](#624)
+ Fix warnings for diagonal matrix format. [#622](#622)
+ Fix criterion factory parameters in CUDA. [#586](#586)
+ Fix the norm-type in the examples. [#612](#612)
+ Fix the WAW race in OpenMP is_sorted_by_column_index. [#617](#617)
+ Fix the example's exec_map by creating the executor only if requested. [#602](#602)
+ Fix some CMake warnings. [#614](#614)
+ Fix Windows building documentation. [#601](#601)
+ Warn when CXX and CUDA host compiler do not match. [#607](#607)
+ Fix reduce_add, prefix_sum, and doc-build. [#593](#593)
+ Fix find_library(cublas) issue on machines installing multiple cuda. [#591](#591)
+ Fix allocator in sellp read. [#589](#589)
+ Fix the CAS with HIP and NVIDIA backends. [#585](#585)

Deletions:
+ Remove unused preconditioner parameter in LowerTrs. [#587](#587)

Related PR: #627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upsj upsj upsj approved these changes

@pratikvn pratikvn pratikvn approved these changes

@thoasm thoasm thoasm approved these changes

@yhmtsai yhmtsai yhmtsai approved these changes

@fritzgoebel fritzgoebel Awaiting requested review from fritzgoebel

Assignees

@tcojean tcojean

Labels
1:ST:ready-to-merge This PR is ready to merge. reg:build This is related to the build system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a warning for mismatching CUDA host compiler and CXX version
5 participants
@tcojean @thoasm @upsj @pratikvn @yhmtsai