Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HIPBLAS CMake #847

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Update HIPBLAS CMake #847

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0b86050
Update HIPBLAS CMake
daniandtheweb Jun 2, 2024
eff6617
Fix HIPBlas for Debian
daniandtheweb Jun 2, 2024
7d9767f
Add hipBLAS build instructions
daniandtheweb Jun 2, 2024
a776869
Fix Clang detection
daniandtheweb Jun 2, 2024
b587ae5
Set ROCM_PATH correctly
daniandtheweb Jun 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Clang detection
  • Loading branch information
@daniandtheweb
daniandtheweb committed Jun 2, 2024
commit a776869492df2912ec22ad01257f9c033a4a1a79
11 changes: 4 additions & 7 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,15 +275,12 @@ if (GGML_HIPBLAS)
string(REGEX MATCH "hipcc(\.bat)?$" CXX_IS_HIPCC "${CMAKE_CXX_COMPILER}")
endif()

if (NOT ${CMAKE_C_COMPILER_ID} MATCHES "Clang")
message(WARNING "Only LLVM is supported for HIP, hint: CC=/opt/rocm/llvm/bin/clang")
endif()
if (NOT ${CMAKE_CXX_COMPILER_ID} MATCHES "Clang")
message(WARNING "Only LLVM is supported for HIP, hint: CXX=/opt/rocm/llvm/bin/clang++")
endif()

if (CXX_IS_HIPCC)
if(LINUX)
if (NOT ${CMAKE_CXX_COMPILER_ID} MATCHES "Clang")
message(WARNING "Only LLVM is supported for HIP, hint: CXX=/opt/rocm/llvm/bin/clang++")
endif()

message(WARNING "Setting hipcc as the C++ compiler is legacy behavior."
" Prefer setting the HIP compiler directly. See README for details.")
endif()
Expand Down