Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code for building HIPBLAS with CMake didn't work at all with my self-built ROCm sdk so I've updated it based on the llama.cpp implementation.
Some newer commit also causes linking problems on Debian Unstable with undefined references to cuda code using hipcc.
This new CMake code works with the self-built packages and it should keep the compatibility with the typical ROCm install made with the package manager (Ubuntu 22.04 and Debian Unstable have been tested and both work fine).
Debian Unstable still needs to build using hipcc as there's no ROCm's Clang available (or at least I haven't found any).