chore(span): Track span origin for analytics #48322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With getsentry/relay#1984, Relay officially accepts a new property on the span called origin. The origin property indicates what precisely created the span. This PR sends origin for opening span details to investigate that data in Amplitude.
|
Hey, @getsentry/performance, I would like a quick review on this one, please 😃 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With getsentry/relay#1984, Relay officially accepts a new property on the span called
origin. The origin property indicates what precisely created the span. This PR sends origin for opening span details to investigate that data in Amplitude. The Amplitude event isPerformance Views: Event Details span details opened. For more information on trace origin, visit the develop docs.The draft PR shows what I roughly would like to achieve. Can someone help me and tell me what else I need to do to finish this PR? Do I also need to update some tests?