feat(protocol): Add origin to trace context and span #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds origin to both trace context and the span. The origin of the span indicates what created the span.
philipphofmann
force-pushed
the
feat/trace-and-span-origin
branch
from
7c96fc6
to
5939cf9
Compare
olksdr
reviewed
Apr 4, 2023
iker-barriocanal
suggested changes
Apr 5, 2023
There was a problem hiding this comment.
We could enforce alphanumeric characters: a-z , A-Z , and 0-9 and underscores: _ as pointed out in the develop docs.
Let's do this. It can easily be done by adding allow_chars to the metastructure of the property, see example. Blocking the PR for this.
philipphofmann
commented
Apr 6, 2023
iker-barriocanal
approved these changes
Apr 6, 2023
relay-general/src/protocol/mod.rs
Outdated
Comment on lines
70
to
72
| /// Origin type such as `auto.http`. | ||
| /// Follows the pattern described in the [develop docs](https://develop.sentry.dev/sdk/performance/trace-origin/). | ||
| pub type OriginType = String; |
There was a problem hiding this comment.
Sorry I missed this earlier, but let's move this to relay-general/protocol/contexts/mod.rs, like OperationType.
philipphofmann
added a commit
to getsentry/sentry
that referenced
this pull request
May 2, 2023
With getsentry/relay#1984, Relay officially accepts a new property on the span called origin. The origin property indicates what precisely created the span. This PR sends origin for opening span details to investigate that data in Amplitude.
philipphofmann
added a commit
to getsentry/sentry
that referenced
this pull request
May 9, 2023
With getsentry/relay#1984, Relay officially accepts a new property on the span called `origin`. The origin property indicates what precisely created the span. This PR sends origin for opening span details to investigate that data in Amplitude. The Amplitude event is [`Performance Views: Event Details span details opened`](https://data.amplitude.com/sentry/sentry.io/events/main/latest/Performance%20Views%3A%20Event%20Details%20span%20details%20opened?view=All&tab=DETAILS&propertyValidityFilter=All%2520Properties). For more information on trace origin, visit the [develop docs](https://develop.sentry.dev/sdk/performance/trace-origin/).
volokluev
pushed a commit
to getsentry/sentry
that referenced
this pull request
May 30, 2023
With getsentry/relay#1984, Relay officially accepts a new property on the span called `origin`. The origin property indicates what precisely created the span. This PR sends origin for opening span details to investigate that data in Amplitude. The Amplitude event is [`Performance Views: Event Details span details opened`](https://data.amplitude.com/sentry/sentry.io/events/main/latest/Performance%20Views%3A%20Event%20Details%20span%20details%20opened?view=All&tab=DETAILS&propertyValidityFilter=All%2520Properties). For more information on trace origin, visit the [develop docs](https://develop.sentry.dev/sdk/performance/trace-origin/).
philipphofmann
added a commit
to getsentry/sentry
that referenced
this pull request
Jun 12, 2023
With getsentry/relay#1984, Relay officially accepts a new property on the span called origin. The origin property indicates what precisely created the span. This PR adds this property in the span details view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds origin to both trace context and the span. The origin of the span indicates what created the span.
Related RFC getsentry/rfcs#73 and develop docs PR getsentry/develop#887