Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Portable PDB debug files and .NET symbolication #39610

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

loewenheim
Copy link
Contributor

@loewenheim loewenheim commented Oct 4, 2022

@loewenheim loewenheim requested a review from a team October 4, 2022 15:44
@loewenheim loewenheim self-assigned this Oct 4, 2022
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Oct 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is simple enough that we can land it right away, even though proper support will require an updated symbolic. Without that, the server will still reject these files.

@Swatinem Swatinem changed the title feat: Add support for portable pdb debug files feat: Add support for Portable PDB debug files and .NET symbolication Oct 17, 2022
@Swatinem Swatinem merged commit dec6ac5 into master Oct 17, 2022
@Swatinem Swatinem deleted the feat/portable-pdb branch October 17, 2022 11:10
barkbarkimashark pushed a commit that referenced this pull request Oct 18, 2022
…#39610)

- This will allow `sentry-cli` to upload Portable PDB debug files. The
companion PR is getsentry/sentry-cli#1345.
- It also allows symbolicator to query/download Portable PDB files.
- The PR also adds support for the protocol types specified in [RFC
0013](getsentry/rfcs#13)

Co-authored-by: Arpad Borsos <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants