feat: Add support for Portable PDB debug files #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support to the `debug-files` subcommand to check, find and upload Portable PDB files.
|
Swatinem
added a commit
to getsentry/sentry
that referenced
this pull request
Oct 17, 2022
…#39610) - This will allow `sentry-cli` to upload Portable PDB debug files. The companion PR is getsentry/sentry-cli#1345. - It also allows symbolicator to query/download Portable PDB files. - The PR also adds support for the protocol types specified in [RFC 0013](getsentry/rfcs#13) Co-authored-by: Arpad Borsos <[email protected]>
Swatinem
changed the title
barkbarkimashark
pushed a commit
to getsentry/sentry
that referenced
this pull request
Oct 18, 2022
…#39610) - This will allow `sentry-cli` to upload Portable PDB debug files. The companion PR is getsentry/sentry-cli#1345. - It also allows symbolicator to query/download Portable PDB files. - The PR also adds support for the protocol types specified in [RFC 0013](getsentry/rfcs#13) Co-authored-by: Arpad Borsos <[email protected]>
kamilogorek
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to the
debug-filessubcommand to check, find and upload Portable PDB files.The actual upload still depends on properly exposing this in sentry.