Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DBAL support to 2.13+ #527

Merged
merged 27 commits into from
Jul 29, 2021
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
cbe825d
Require at least DBAL 2.13 to leverage the FC layer
Jean85 Jun 23, 2021
4643c20
Remove Driver and Middleware aliases
Jean85 Jun 23, 2021
72c0625
Add DBAL version check to compiler pass
Jean85 Jun 23, 2021
a524d17
Restore deleted use statement
Jean85 Jun 23, 2021
3b2918b
Fix edge case test with class_alias
Jean85 Jun 23, 2021
8fc8f57
Wrap stub definition in check for DBAL presence
Jean85 Jun 23, 2021
3675b2f
Fix test skipping in CI
Jean85 Jun 23, 2021
9e55351
Fix CS
Jean85 Jun 23, 2021
4c28ca9
Fix test
Jean85 Jun 23, 2021
a44045b
Skip test if DBAL is missing
Jean85 Jun 23, 2021
32b1a12
Restore Middleware alias since it's totaly missing in DBAL v2
Jean85 Jul 7, 2021
7518646
Fix DBAL v2 detection in tests
Jean85 Jul 7, 2021
f9cf23d
Fix or ignore PHPStan errors
Jean85 Jul 7, 2021
0491c39
Remove TODO
Jean85 Jul 7, 2021
f261716
Add changelog entry
Jean85 Jul 7, 2021
84fdec5
Address CR comments
Jean85 Jul 9, 2021
afb77bc
Fix interface existence check
Jean85 Jul 9, 2021
e437dcc
Revert wrong change
Jean85 Jul 9, 2021
62b026e
Fix PHPStan baseline
Jean85 Jul 9, 2021
197de3d
Increase Psalm baseline
Jean85 Jul 9, 2021
2c773c9
Fix baselines, again
Jean85 Jul 9, 2021
b50e71c
Refactor DBAL version check
Jean85 Jul 9, 2021
88efd92
Fix exception message assertion
Jean85 Jul 9, 2021
4a1b4b0
Address CR comments
Jean85 Jul 27, 2021
18c02fb
Merge branch 'develop' into bump-dbal-support
Jean85 Jul 27, 2021
96b5765
Fix test expectation
Jean85 Jul 27, 2021
e90450e
Simplify assert method
Jean85 Jul 29, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Restore deleted use statement
  • Loading branch information
Jean85 committed Jul 7, 2021
commit a524d17f756423cf03d2bafc77955914bef1b5ec
1 change: 1 addition & 0 deletions src/Tracing/Doctrine/DBAL/TracingDriver.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
namespace Sentry\SentryBundle\Tracing\Doctrine\DBAL;

use Doctrine\DBAL\Connection;
use Doctrine\DBAL\Driver\API\ExceptionConverter;
use Doctrine\DBAL\Driver as DBALDriver;
Jean85 marked this conversation as resolved.
Show resolved Hide resolved
use Doctrine\DBAL\Driver\DriverException as LegacyDriverExceptionInterface;
use Doctrine\DBAL\Driver\ExceptionConverterDriver as ExceptionConverterDriverInterface;
Expand Down