Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DBAL support to 2.13+ #527

Merged
merged 27 commits into from
Jul 29, 2021
Merged

Bump DBAL support to 2.13+ #527

merged 27 commits into from
Jul 29, 2021

Conversation

Jean85
Copy link
Collaborator

@Jean85 Jean85 commented Jun 23, 2021

WIP

This bumps the requirement for DBAL tracing to ^2.13 | ^3; this in turn allows us to leverage the wider FC layer present in 2.13, reducing a lot our effort.

This is an alternative to #512, with a complete different approach as suggested in #512 (review)

This should also fix #483 as a side effect.

@Jean85 Jean85 added this to the 4.2 milestone Jun 23, 2021
@Jean85 Jean85 self-assigned this Jun 23, 2021
@Jean85 Jean85 marked this pull request as ready for review July 7, 2021 21:44
@Jean85 Jean85 mentioned this pull request Jul 7, 2021
src/DependencyInjection/Compiler/DbalTracingPass.php Outdated Show resolved Hide resolved
src/Tracing/Doctrine/DBAL/TracingDriver.php Outdated Show resolved Hide resolved
src/Tracing/Doctrine/DBAL/TracingDriver.php Outdated Show resolved Hide resolved
tests/Tracing/Doctrine/DBAL/TracingDriverTest.php Outdated Show resolved Hide resolved
@Jean85 Jean85 requested a review from ste93cry July 9, 2021 09:53
@Jean85 Jean85 requested a review from ste93cry July 27, 2021 11:01
Copy link
Collaborator

@ste93cry ste93cry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nitpicks and then LGTM for me

src/DependencyInjection/Compiler/DbalTracingPass.php Outdated Show resolved Hide resolved
src/DependencyInjection/Compiler/DbalTracingPass.php Outdated Show resolved Hide resolved
@Jean85 Jean85 requested a review from ste93cry July 29, 2021 06:37
@ste93cry ste93cry merged commit 1bffee8 into develop Jul 29, 2021
@ste93cry ste93cry deleted the bump-dbal-support branch July 29, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants