Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raven_Client#user_context() no longer accepts $data = null as of 1.6.0 #388

Closed
ianfp opened this issue Dec 14, 2016 · 2 comments
Closed

Raven_Client#user_context() no longer accepts $data = null as of 1.6.0 #388

ianfp opened this issue Dec 14, 2016 · 2 comments

Comments

@ianfp
Copy link

ianfp commented Dec 14, 2016

This commit breaks backwards-compatibility because if null is passed, the array_merge() triggers a PHP warning (which in my app is converted to an exception).

And indeed, null is sometimes passed. Monolog's RavenHandler does just that.
dcramer added a commit that referenced this issue Dec 14, 2016
@dcramer
Correct handling of null in user_context (fixes GH-388)
b7aa6c6
@dcramer
Copy link
Member

dcramer commented Dec 14, 2016

should be fixed in 1.6.1

This was referenced Dec 14, 2016
Closed
Closed
@ianfp
Copy link
Author

ianfp commented Dec 14, 2016

Confirmed, 1.6.1 fixes the issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcramer @ianfp