Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raven_Client#user_context() no longer accepts null as of 1.6.0 #904

Closed
ianfp opened this issue Dec 14, 2016 · 1 comment
Closed

Raven_Client#user_context() no longer accepts null as of 1.6.0 #904

ianfp opened this issue Dec 14, 2016 · 1 comment

Comments

@ianfp
Copy link

ianfp commented Dec 14, 2016

This change in sentry-php 1.6.0 means that Raven_Client#user_context() no longer accepts null as the first argument. Passing null now generates a PHP Warning because the null value is passed to array_merge().

I've filed the issue against sentry-php here because it's a backward-compatibility break, but perhaps we should consider only passing arrays to that method from now on. The problematic line in RavenHander is here.

@Seldaek
Copy link
Owner

Seldaek commented Dec 15, 2016

Been fixed in 1.6.1 of sentry I believe so closing this.

@Seldaek Seldaek closed this as completed Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants