feat: Add context data to events #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To properly display those contexts, we still need some changes in the Sentry Context UI. Especially, if we want to provide consistent rendering - see #40 for more details. |
timfish
reviewed
Apr 16, 2018
src/frontend.ts
Outdated
| scope: Scope, | ||
| ): Promise<SentryEvent> { | ||
| const prepared = await super.prepareEvent(event, scope); | ||
| return addEventDefaults(prepared); |
There was a problem hiding this comment.
What stops this being called from the renderer process?
All the app and process access in context.ts will only work from the main process.
There was a problem hiding this comment.
Actually its protected and throws from sendEvent so this should be fine
There was a problem hiding this comment.
We can add a guard and throw in case someone tries to invoke it 👍
timfish
approved these changes
Apr 16, 2018
HazAT
approved these changes
Apr 16, 2018
|
Updated, this should be ready to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operating system version is still wrong and I think we can do a better job in getting the operating system name (e.g. via user agent).
Fixes #37
Fixes #40