Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use better defaults for some options #37

Closed
jan-auer opened this issue Mar 13, 2018 · 2 comments
Closed

Use better defaults for some options #37

jan-auer opened this issue Mar 13, 2018 · 2 comments
Labels
Type: Enhancement

Comments

@jan-auer
Copy link
Member

  • release - app.getName() + app.getVersion()
  • environment - process.defaultApp ? 'development' : 'packaged'
  • user.id - node-machine-id.machineId()
@timfish
Copy link
Collaborator

timfish commented Mar 13, 2018 •
edited

After suggesting node-machine-id I found this issue which could become a pain and we don't require anything quite so persistent.

Maybe a uuid will be enough.

@jan-auer jan-auer mentioned this issue Apr 13, 2018
Merged
@jan-auer
Copy link
Member Author

I think we'll leave the machine ID out. Besides, that should rather be in app.device_app_hash and the user.id should identify the authenticated user, if the app has such a concept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timfish @jan-auer