Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different approach to editing permissions of docker volumes #3084

Merged
merged 6 commits into from
May 29, 2024
Merged

Different approach to editing permissions of docker volumes #3084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac43f43
different approach to editing permissions of docker volumes
hubertdeng123 May 28, 2024
6034c10
Merge branch 'master' into hubertdeng123/non-sudo-edit-docker-volume-…
hubertdeng123 May 28, 2024
c6389e8
use correct zookeeper-log volume name
hubertdeng123 May 28, 2024
d6fa2fa
use actual correct zookeeper-log volume name
hubertdeng123 May 28, 2024
a792df0
use latest tag again
hubertdeng123 May 28, 2024
ff998a5
run script for all platforms
hubertdeng123 May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,7 @@ jobs:
uses: actions/checkout@v4

- name: Install current ref
run: |
# Hacky way to get around permissioning issues in update-docker-volume-permissions.sh script
sudo -E ./install.sh
run: ./install.sh

integration-test:
if: github.repository_owner == 'getsentry'
Expand Down
11 changes: 2 additions & 9 deletions install/update-docker-volume-permissions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,8 @@ echo "${_group}Ensuring Kafka and Zookeeper volumes have correct permissions ...

# Only supporting platforms on linux x86 platforms and not apple silicon. I'm assuming that folks using apple silicon are doing it for dev purposes and it's difficult
# to change permissions of docker volumes since it is run in a VM.
if [[ "$DOCKER_PLATFORM" = "linux/amd64" && -n "$(docker volume ls -q -f name=sentry-zookeeper)" && -n "$(docker volume ls -q -f name=sentry-kafka)" ]]; then
docker_root_dir=$(docker info --format '{{.DockerRootDir}}')
zookeeper_data_dir="${docker_root_dir}/volumes/sentry-zookeeper/_data"
kafka_data_dir="${docker_root_dir}/volumes/sentry-kafka/_data"
zookeeper_log_data_dir="${docker_root_dir}/volumes/${COMPOSE_PROJECT_NAME}_sentry-zookeeper-log/_data"
chmod -R a+w $zookeeper_data_dir $kafka_data_dir $zookeeper_log_data_dir && returncode=$? || returncode=$?
if [[ $returncode == "1" ]]; then
echo "WARNING: Error when setting appropriate permissions for zookeeper, kafka, and zookeeper log docker volumes. This may corrupt your self-hosted install. See https://github.com/confluentinc/kafka-images/issues/127 for context on why this was added."
fi
if [[ -n "$(docker volume ls -q -f name=sentry-zookeeper)" && -n "$(docker volume ls -q -f name=sentry-kafka)" ]]; then
docker run --rm -v "sentry-zookeeper:/sentry-zookeeper-data" -v "sentry-kafka:/sentry-kafka-data" -v "${COMPOSE_PROJECT_NAME}_sentry-zookeeper-log:/sentry-zookeeper-log-data" busybox chmod -R a+w /sentry-zookeeper-data /sentry-kafka-data /sentry-zookeeper-log-data
fi

echo "${_endgroup}"
Loading