Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different approach to editing permissions of docker volumes #3084

Merged

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented May 28, 2024

Previously, we were using sudo -E ./install.sh to get around permissioning issues in CI when setting docker volume permissions. Using this approach, sudo is no longer needed in the install script to modify docker permissions if users do not have access to the docker volume directories

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (6032d98) to head (ff998a5).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3084   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files           3        3           
  Lines         203      203           
=======================================
  Hits          201      201           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hubertdeng123 hubertdeng123 marked this pull request as ready for review May 28, 2024 19:32
@hubertdeng123 hubertdeng123 force-pushed the hubertdeng123/non-sudo-edit-docker-volume-permissions branch 2 times, most recently from e07021c to a792df0 Compare May 28, 2024 22:00
@hubertdeng123 hubertdeng123 merged commit 0dabb5a into master May 29, 2024
13 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/non-sudo-edit-docker-volume-permissions branch May 29, 2024 18:30
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants