Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum docker compose requirement #3078

Merged
merged 2 commits into from
May 29, 2024

Conversation

JannKleen
Copy link
Contributor

@JannKleen JannKleen commented May 27, 2024

Closes #3070

docker compose down is now required in https://github.com/getsentry/self-hosted/blob/master/install/upgrade-clickhouse.sh#L27.
Here is the corresponding docker compose Changelog: https://docs.docker.com/compose/release-notes/#bug-fixes-and-enhancements-19

I was running the install script using docker compose v2.18.1, and the install failed with:

 Container sentry-self-hosted-clickhouse-1  Running
sentry-self-hosted-clickhouse-1   clickhouse-self-hosted-local   "/entrypoint.sh"    clickhouse          4 minutes ago       Up 31 seconds (healthy)   8123/tcp, 9000/tcp, 9009/tcp
unknown command "clickhouse" for "docker compose down"
Error in install/upgrade-clickhouse.sh:23.
'$dc down clickhouse' exited with status 1
-> ./install.sh:main:25
--> install/upgrade-clickhouse.sh:source:23

Looks like you've already sent this error to us, we're on it :)

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (6917e39) to head (4397640).

Current head 4397640 differs from pull request most recent head faa51af

Please upload reports for the commit faa51af to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3078   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files           3        3           
  Lines         203      203           
=======================================
  Hits          201      201           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hubertdeng123 hubertdeng123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README will also need to be updated. Would you be able to make that change?

@JannKleen
Copy link
Contributor Author

@hubertdeng123 Thanks, good catch, I changed the version in the README.

@azaslavsky azaslavsky self-requested a review May 29, 2024 16:16
@hubertdeng123 hubertdeng123 merged commit c40b153 into getsentry:master May 29, 2024
9 checks passed
@JannKleen JannKleen deleted the patch-1 branch May 30, 2024 10:03
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
5 participants