Skip to content

Commit

Permalink
Update minimum docker compose requirement (#3078)
Browse files Browse the repository at this point in the history
* Update minimum docker compose requirement

docker compose down <service> is now required.

* Update docker compose version to new minimum in CI config.
  • Loading branch information
JannKleen committed May 29, 2024
1 parent 0dabb5a commit c40b153
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ jobs:
fail-fast: false
matrix:
customizations: ["disabled", "enabled"]
compose_version: ["v2.0.1", "v2.26.0"]
compose_version: ["v2.19.0", "v2.26.0"]
include:
- compose_version: "v2.0.1"
- compose_version: "v2.19.0"
compose_path: "/usr/local/lib/docker/cli-plugins"
- compose_version: "v2.26.0"
compose_path: "/usr/local/lib/docker/cli-plugins"
Expand Down Expand Up @@ -134,7 +134,7 @@ jobs:

- name: Integration Test
run: |
if [ "${{ matrix.compose_version }}" = "v2.0.1" ]; then
if [ "${{ matrix.compose_version }}" = "v2.19.0" ]; then
pytest --reruns 3 --cov --junitxml=junit.xml _integration-test/ --customizations=${{ matrix.customizations }}
else
pytest --cov --junitxml=junit.xml _integration-test/ --customizations=${{ matrix.customizations }}
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Official bootstrap for running your own [Sentry](https://sentry.io/) with [Docke
## Requirements

* Docker 19.03.6+
* Compose 2.0.1+
* Compose 2.19.0+
* 4 CPU Cores
* 16 GB RAM
* 20 GB Free Disk Space
Expand Down
2 changes: 1 addition & 1 deletion install/_min-requirements.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Don't forget to update the README and othes docs when you change these!
MIN_DOCKER_VERSION='19.03.6'
MIN_COMPOSE_VERSION='2.0.1'
MIN_COMPOSE_VERSION='2.19.0'
MIN_RAM_HARD=3800 # MB
MIN_RAM_SOFT=7800 # MB
MIN_CPU_HARD=2
Expand Down

0 comments on commit c40b153

Please sign in to comment.