Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump kafka and zookeeper versions #2988

Merged
merged 9 commits into from
Apr 30, 2024
+18 −2
Merged

Bump kafka and zookeeper versions #2988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b06aed7
bump kafka and zookeeper versions
hubertdeng123 Apr 22, 2024
ee35727
add script to modify docker volume permissions
hubertdeng123 Apr 26, 2024
b06bb44
Merge branch 'master' into hubertdeng123/bump-kafka-zookeeper
hubertdeng123 Apr 26, 2024
d7a7f7d
debug why tests are failing
hubertdeng123 Apr 26, 2024
17c9f38
Merge branch 'master' into hubertdeng123/bump-kafka-zookeeper
hubertdeng123 Apr 26, 2024
e758d23
give warning message to users if appropriate permissions are not set …
hubertdeng123 Apr 29, 2024
99372f1
Merge branch 'master' into hubertdeng123/bump-kafka-zookeeper
hubertdeng123 Apr 29, 2024
f159ddd
revert pytest flag
hubertdeng123 Apr 29, 2024
00959b3
link appropriate issue
hubertdeng123 Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ services:
target: /opt/sentry/
zookeeper:
<<: *restart_policy
image: "confluentinc/cp-zookeeper:5.5.7"
image: "confluentinc/cp-zookeeper:7.6.1"
environment:
ZOOKEEPER_CLIENT_PORT: "2181"
CONFLUENT_SUPPORT_METRICS_ENABLE: "false"
Expand All @@ -184,7 +184,7 @@ services:
depends_on:
zookeeper:
<<: *depends_on-healthy
image: "confluentinc/cp-kafka:5.5.7"
image: "confluentinc/cp-kafka:7.6.1"
environment:
KAFKA_ZOOKEEPER_CONNECT: "zookeeper:2181"
KAFKA_ADVERTISED_LISTENERS: "PLAINTEXT:https://kafka:9092"
Expand Down
1 change: 1 addition & 0 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ source install/check-minimum-requirements.sh

# Let's go! Start impacting things.
source install/turn-things-off.sh
source install/update-docker-volume-permissions.sh
source install/create-docker-volumes.sh
source install/ensure-files-from-examples.sh
source install/check-memcached-backend.sh
Expand Down
15 changes: 15 additions & 0 deletions install/update-docker-volume-permissions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
echo "${_group}Ensuring Kafka and Zookeeper volumes have correct permissions ..."

# Only supporting platforms on linux x86 platforms and not apple silicon. I'm assuming that folks using apple silicon are doing it for dev purposes and it's difficult
# to change permissions of docker volumes since it is run in a VM.
if [[ "$DOCKER_PLATFORM" = "linux/amd64" && -n "$(docker volume ls -q -f name=sentry-zookeeper)" && -n "$(docker volume ls -q -f name=sentry-kafka)" ]]; then
zookeeper_data_dir="/var/lib/docker/volumes/sentry-zookeeper/_data"
kafka_data_dir="/var/lib/docker/volumes/sentry-kafka/_data"
zookeeper_log_data_dir="/var/lib/docker/volumes/sentry-self-hosted_sentry-zookeeper-log/_data"
chmod -R a+w $zookeeper_data_dir $kafka_data_dir $zookeeper_log_data_dir && returncode=$? || returncode=$?
if [[ $returncode == "1" ]]; then
echo "WARNING: Error when setting appropriate permissions for zookeeper, kafka, and zookeeper log docker volumes. This may corrupt your self-hosted install. See https://github.com/confluentinc/kafka-images/issues/127 for context on why this was added."
fi
fi

echo "${_endgroup}"
Loading