Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kafka and zookeeper versions #2988

Merged
merged 9 commits into from
Apr 30, 2024
Prev Previous commit
Next Next commit
give warning message to users if appropriate permissions are not set …
…properly for docker volumes
  • Loading branch information
hubertdeng123 committed Apr 29, 2024
commit e758d23f3c0a7c61fa2f10a39d497b3d3d896516
10 changes: 7 additions & 3 deletions install/update-docker-volume-permissions.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@ echo "${_group}Ensuring Kafka and Zookeeper volumes have correct permissions ...
# Only supporting platforms on linux x86 platforms and not apple silicon. I'm assuming that folks using apple silicon are doing it for dev purposes and it's difficult
# to change permissions of docker volumes since it is run in a VM.
if [[ "$DOCKER_PLATFORM" = "linux/amd64" && -n "$(docker volume ls -q -f name=sentry-zookeeper)" && -n "$(docker volume ls -q -f name=sentry-kafka)" ]]; then
chmod -R a+w /var/lib/docker/volumes/sentry-zookeeper/_data || true
chmod -R a+w /var/lib/docker/volumes/sentry-kafka/_data || true
chmod -R a+w /var/lib/docker/volumes/sentry-self-hosted_sentry-zookeeper-log/_data || true
zookeeper_data_dir="/var/lib/docker/volumes/sentry-zookeeper/_data"
kafka_data_dir="/var/lib/docker/volumes/sentry-kafka/_data"
zookeeper_log_data_dir="/var/lib/docker/volumes/sentry-self-hosted_sentry-zookeeper-log/_data"
chmod -R a+w $zookeeper_data_dir $kafka_data_dir $zookeeper_log_data_dir && returncode=$? || returncode=$?
if [[ $returncode == "1" ]]; then
echo "WARNING: Error when setting appropriate permissions for zookeeper, kafka, and zookeeper log docker volumes. This may corrupt your self-hosted install."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we point to a bug or doc with more info? It seems like users could recover from this manually if this script fails for some reason.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linked to a bug to give users more context

fi
fi

echo "${_endgroup}"
Loading