feat: upgrade to zookeeper-less kafka #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BYK
reviewed
Oct 3, 2023
aminvakil
reviewed
Oct 3, 2023
| KAFKA_CONTROLLER_QUORUM_VOTERS: "[email protected]:29093" | ||
| KAFKA_CONTROLLER_LISTENER_NAMES: "CONTROLLER" | ||
| KAFKA_NODE_ID: "1" | ||
| CLUSTER_ID: "MkU3OEVBNTcwNTJENDM2Qk" |
There was a problem hiding this comment.
Could we generate a UUID for CLUSTER_ID value instead of hard-coding a single string for every instance?
There was a problem hiding this comment.
There aren't any benefits I can think of from doing so. It's just used for cluster coordination.
There was a problem hiding this comment.
We can leverage this existing code if we wanted to:
hubertdeng123
approved these changes
Oct 17, 2023
hubertdeng123
added a commit
that referenced
this pull request
Oct 18, 2023
This reverts commit a177142.
hubertdeng123
added a commit
that referenced
this pull request
Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've upgraded to zookeeper-less kafka upstream: getsentry/sentry#55742
This simplifies the self-hosted environment and makes things leaner with less moving parts.