-
Notifications
You must be signed in to change notification settings - Fork 202
Comparing changes
Open a pull request
base repository: getporter/porter
base: v1.0.10
head repository: getporter/porter
compare: v1.0.11
- 20 commits
- 44 files changed
- 4 contributors
Commits on Mar 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bac5117 - Browse repository at this point
Copy the full SHA bac5117View commit details
Commits on Mar 23, 2023
-
Document why we use require in long tests (#2643)
* Document why we use require in long tests This is follow up to #2641 (comment) which documents why we use require in integration/smoke tests instead of assert. Signed-off-by: Carolyn Van Slyck <[email protected]> * Apply suggestions from code review Co-authored-by: Aaron Schlesinger <[email protected]> Signed-off-by: Carolyn Van Slyck <[email protected]> --------- Signed-off-by: Carolyn Van Slyck <[email protected]> Co-authored-by: Aaron Schlesinger <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8c3855d - Browse repository at this point
Copy the full SHA 8c3855dView commit details
Commits on Mar 26, 2023
-
Bump go.mongodb.org/mongo-driver from 1.11.2 to 1.11.3
Bumps [go.mongodb.org/mongo-driver](https://github.com/mongodb/mongo-go-driver) from 1.11.2 to 1.11.3. - [Release notes](https://github.com/mongodb/mongo-go-driver/releases) - [Commits](mongodb/mongo-go-driver@v1.11.2...v1.11.3) --- updated-dependencies: - dependency-name: go.mongodb.org/mongo-driver dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bc6bc3f - Browse repository at this point
Copy the full SHA bc6bc3fView commit details -
Bump github.com/hashicorp/go-hclog from 1.4.0 to 1.5.0
Bumps [github.com/hashicorp/go-hclog](https://github.com/hashicorp/go-hclog) from 1.4.0 to 1.5.0. - [Release notes](https://github.com/hashicorp/go-hclog/releases) - [Commits](hashicorp/go-hclog@v1.4.0...v1.5.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/go-hclog dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5d0f47c - Browse repository at this point
Copy the full SHA 5d0f47cView commit details -
Bump google.golang.org/grpc from 1.53.0 to 1.54.0
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.53.0 to 1.54.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.53.0...v1.54.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b1de27f - Browse repository at this point
Copy the full SHA b1de27fView commit details
Commits on Mar 27, 2023
-
Some files in the pkg/cnab package were not named in a way that matches the structs inside. I have renamed the files so that they are easier to find. Signed-off-by: Carolyn Van Slyck <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 91f1575 - Browse repository at this point
Copy the full SHA 91f1575View commit details -
Consolidate required extensions into extensions file
More tidying up so that it's easier to find related code. Signed-off-by: Carolyn Van Slyck <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 89d89bf - Browse repository at this point
Copy the full SHA 89d89bfView commit details -
Move v1 implementation of cnab dependencies into separate package
Create a new package containing the CNAB types and structs to manage dependencies v1 Signed-off-by: Carolyn Van Slyck <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 99ef0da - Browse repository at this point
Copy the full SHA 99ef0daView commit details -
Improve passing custom values as build arguments (#2641)
* Improve passing custom values as build arguments Currently porter passes all custom values defined in porter.yaml as build arguments when using docker to build the invocation image. ```yaml custom: app: version: 1.2.3 ``` The above porter.yaml results in porter passing --build-arg CUSTOM_APP_VERSION=1.2.3 We have some users who are storing longer values in the custom map and have managed to hit the max argument length on their system. To address this, I am no longer passing all custom values as build arguments, and only pass them when the Dockerfile declares a build argument with the same name. In the example above, we only pass the app version when the Dockerfile declares `ARG CUSTOM_APP_VERSION`. In this users's case that's enough to avoid the problem. In addition to the change above, I have also added a max length check on build arguments so that we can detect that it may be too long and provide a better error message. When we let the large value get passed to docker the error is simply "exit code 1" and we don't get any context into what failed. This will ensure that long values are caught before calling docker and telling the user to save the value in a file, and then read it back out in the Dockerfile instead. Signed-off-by: Carolyn Van Slyck <[email protected]> * Document max length on --custom field Signed-off-by: Carolyn Van Slyck <[email protected]> * Improve readability * Use code blocks such as `porter build --build-arg` instead of "--build-arg flag on porter build". It reads more cleanly when someone is just reading the markdown and not the rendered HTML * Split function arguments onto seprate lines since they are long lines Signed-off-by: Carolyn Van Slyck <[email protected]> * Fix build test I was being too clever trying to deal with cachebusting the dockerfile and it totally wasn't necesary. I've simplified the test and fixed the typo Signed-off-by: Carolyn Van Slyck <[email protected]> --------- Signed-off-by: Carolyn Van Slyck <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7d35c81 - Browse repository at this point
Copy the full SHA 7d35c81View commit details -
Merge pull request #2658 from carolynvs/refactor-cnab
Refactor CNAB package in preparation for dependencies v2
Configuration menu - View commit details
-
Copy full SHA for 7a81fa5 - Browse repository at this point
Copy the full SHA 7a81fa5View commit details -
Remove name field from CNAB dependency representation in bundle.json
The name field for a dependency is not in the spec because CNAB represents a dependency as a map entry, keyed by name. We use a name internally just to make things easier while working with dependency entries but they shouldn't be written out with a name field. I have updated how we serialize the dependency structs so that even when name is populated, we don't write it to bundle.json. Signed-off-by: Carolyn Van Slyck <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fd0d90e - Browse repository at this point
Copy the full SHA fd0d90eView commit details
Commits on Mar 28, 2023
-
Merge pull request #2642 from Arhell/fix-list
Accessibility fix list
Configuration menu - View commit details
-
Copy full SHA for 1070aa5 - Browse repository at this point
Copy the full SHA 1070aa5View commit details -
Merge pull request #2655 from getporter/dependabot/go_modules/google.…
…golang.org/grpc-1.54.0 Bump google.golang.org/grpc from 1.53.0 to 1.54.0
Configuration menu - View commit details
-
Copy full SHA for 702376b - Browse repository at this point
Copy the full SHA 702376bView commit details -
Merge pull request #2654 from getporter/dependabot/go_modules/github.…
…com/hashicorp/go-hclog-1.5.0 Bump github.com/hashicorp/go-hclog from 1.4.0 to 1.5.0
Configuration menu - View commit details
-
Copy full SHA for 32f0094 - Browse repository at this point
Copy the full SHA 32f0094View commit details -
Merge pull request #2652 from getporter/dependabot/go_modules/go.mong…
…odb.org/mongo-driver-1.11.3 Bump go.mongodb.org/mongo-driver from 1.11.2 to 1.11.3
Configuration menu - View commit details
-
Copy full SHA for b87d69d - Browse repository at this point
Copy the full SHA b87d69dView commit details -
Merge pull request #2660 from carolynvs/depsv1-remove-name
Remove name field from CNAB dependency representation in bundle.json
Configuration menu - View commit details
-
Copy full SHA for c2625f6 - Browse repository at this point
Copy the full SHA c2625f6View commit details
Commits on Mar 29, 2023
-
Bump github.com/opencontainers/runc from 1.1.3 to 1.1.5
Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc) from 1.1.3 to 1.1.5. - [Release notes](https://github.com/opencontainers/runc/releases) - [Changelog](https://github.com/opencontainers/runc/blob/v1.1.5/CHANGELOG.md) - [Commits](opencontainers/runc@v1.1.3...v1.1.5) --- updated-dependencies: - dependency-name: github.com/opencontainers/runc dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7610436 - Browse repository at this point
Copy the full SHA 7610436View commit details -
Merge pull request #2664 from getporter/dependabot/go_modules/github.…
…com/opencontainers/runc-1.1.5 Bump github.com/opencontainers/runc from 1.1.3 to 1.1.5
Configuration menu - View commit details
-
Copy full SHA for 763c537 - Browse repository at this point
Copy the full SHA 763c537View commit details -
Updates to bundle schema v1.0.1
* Default schemaVersion to 1.0.1. Now when someone in VS Code inserts a schemaVersion field it is defaulted to 1.0.1 for them automatically. * Fix typo in spelling of definition * Provide better json schema for dependency parameters, previously we only defined it as an object. I've added a description and requires the parameter keys to be strings Signed-off-by: Carolyn Van Slyck <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ec4e3cc - Browse repository at this point
Copy the full SHA ec4e3ccView commit details -
Merge pull request #2665 from carolynvs/schema-fixes
Updates to bundle schema v1.0.1
Configuration menu - View commit details
-
Copy full SHA for c8d99b7 - Browse repository at this point
Copy the full SHA c8d99b7View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.0.10...v1.0.11