Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to bundle schema v1.0.1 #2665

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Conversation

carolynvs
Copy link
Member

What does this change

  • Default schemaVersion to 1.0.1. Now when someone in VS Code inserts a schemaVersion field it is defaulted to 1.0.1 for them automatically.
  • Fix typo in spelling of definition
  • Provide better json schema for dependency parameters, previously we only defined it as an object. I've added a description and requires the parameter keys to be strings

What issue does it fix

Just minor gaps in our current manifest schema that I found when updating the schema for PEP003

Notes for the reviewer

N/A

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

* Default schemaVersion to 1.0.1. Now when someone in VS Code inserts a schemaVersion field it is defaulted to 1.0.1 for them automatically.
* Fix typo in spelling of definition
* Provide better json schema for dependency parameters, previously we only defined it as an object. I've added a description and requires the parameter keys to be strings

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs carolynvs marked this pull request as ready for review March 29, 2023 20:03
@carolynvs carolynvs requested a review from arschles March 29, 2023 20:03
@carolynvs carolynvs merged commit c8d99b7 into getporter:main Mar 29, 2023
@carolynvs carolynvs deleted the schema-fixes branch March 29, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants