Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CNAB package in preparation for dependencies v2 #2658

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Refactor CNAB package in preparation for dependencies v2 #2658

merged 3 commits into from
Mar 27, 2023

Conversation

carolynvs
Copy link
Member

  • Rename some CNAB package files to match their contents
  • Consolidate the required extension logic into the extensions.go file so it's easier to find.
  • Move v1 implementation of CNAB dependencies into separate package

@carolynvs
Rename cnab package files
91f1575 
Some files in the pkg/cnab package were not named in a way that matches the structs inside. I have renamed the files so that they are easier to find.

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs
Consolidate required extensions into extensions file
89d89bf 
More tidying up so that it's easier to find related code.

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs
Move v1 implementation of cnab dependencies into separate package
99ef0da 
Create a new package containing the CNAB types and structs to manage dependencies v1

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs carolynvs added the pep003-advanced-dependencies Implementation of the Advanced Dependencies proposal label Mar 27, 2023
arschles
arschles approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carolynvs carolynvs merged commit 7a81fa5 into getporter:main Mar 27, 2023
@carolynvs carolynvs deleted the refactor-cnab branch March 27, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arschles arschles arschles approved these changes

@VinozzZ VinozzZ Awaiting requested review from VinozzZ

@sgettys sgettys Awaiting requested review from sgettys sgettys is a code owner

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter is a code owner

@joshuabezaleel joshuabezaleel Awaiting requested review from joshuabezaleel

@vdice vdice Awaiting requested review from vdice

Assignees
No one assigned
Labels
pep003-advanced-dependencies Implementation of the Advanced Dependencies proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carolynvs @arschles