Removed the regression test package [Final part] #6383
Conversation
| val chain: RuleChain = TestRuleChain.chain().around(rule) | ||
|
|
||
| @Test | ||
| fun sortByDialog_ShouldBeTranslatedAndDisplayProperIcons() { |
There was a problem hiding this comment.
I think we can ditch this test. We use string resources for the options (and Android Lint would shout at us if we didn't). I don't think this is worth dedicating a connected test to.
| val ruleChain: RuleChain = TestRuleChain.chain().around(rule) | ||
|
|
||
| @Test | ||
| fun typeMismatchErrorMessage_shouldBeDisplayedWhenItOccurs() { |
There was a problem hiding this comment.
Could this go in CatchFormDesignExceptionsTest instead?
| val formsDirPath = StoragePathProvider().getOdkDirPath(StorageSubdirectory.FORMS) | ||
|
|
||
| rule.startAtMainMenu() | ||
| .copyForm("search_and_select.xml") |
There was a problem hiding this comment.
I think we could split these out into their relevant select tests (ExternalSelectsTest, ExternalSecondaryInstanceTest etc)
| val ruleChain: RuleChain = TestRuleChain.chain().around(rule) | ||
|
|
||
| @Test | ||
| fun randomFunction_ShouldWorkCorrectly() { |
There was a problem hiding this comment.
This feels like it should be covered in JavaRosa? Does Collect actually implement anything to do with random()?
There was a problem hiding this comment.
Does Collect actually implement anything to do with random()?
I don't think so. Ok we can gett rid of this.
| val ruleChain: RuleChain = TestRuleChain.chain().around(rule) | ||
|
|
||
| @Test | ||
| fun searchAppearance_ShouldDisplayWhenSearchAppearanceIsSpecified() { |
There was a problem hiding this comment.
I get that this is trying to make sure search works everywhere it should work (which makes sense to have in one test), but can we cut it down in any way? I don't think we need to assert on every result at this level right?
There was a problem hiding this comment.
I spit it into smaller tests you are right the big one didn't make sense.
…o a separate class
…FormDesignExceptionsTest
f742af8
to
e484e2e
Compare
Why is this the best possible solution? Were any other approaches considered?
This is the final part of #5983 which contains commits 30-42.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It doesn't require testing.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest