-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the regression test package #5983
Conversation
@grzesiek2010 there's some conflicts here now (probably because of #6059 - sorry 😔). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ormManagementTest
…onverted to kotlin
…e to FormHierarchyTest
…ate class in the formmanagement package
…o a separate class
c2dd05b
to
4c4ec7a
Compare
Fixed. |
Github doesn't let me track where I am in a review by commit so I'll just track it in this comment. Latest commit |
I'm frankly finding it hard to find time to fit this in. @grzesiek2010 are you able just pull the commits after 74cbd26 onto another branch for the moment? I think this will be much easier to review and merge in chunks rather than all at once and there's no reason we need to make the change in one go. |
Let's keep this pr. I will convert it to a draft. There is a new one that contains the commits you have reviewed #6142 |
I'm closing in favor of #6383 |
Why is this the best possible solution? Were any other approaches considered?
The regression package was a set of tests written by the QA team. It's been a while since the QA team added something there and we have decided that it will no longer be their responsibility.
I have reviewed the tests:
The test cases that were covered by the tests I've removed are still performed manually by the QA team during regression testing I belive so it shouldn't be dangerous.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It doesn't require testing.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still pass