feat: Allow alternate S3 compatible storages #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
added
the
issue: enhancement
rsempe
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The
aws-s3-sdkgem that we are using to manage document storage (for invoice) allows the usage of S3 compatible services.This feature has been requested multiple #90 and we already tried to address it (getlago/lago-api#355) but it ended on some trouble on our cloud environment and the change was reverted.
Description
This PR is a new attempt to address the feature by adding an alternate s3 configuration when
LAGO_AWS_S3_ENDPOINTthe environment variable is present in the configuration.Related tasks
PR on lago-api: getlago/lago-api#380
How Has This Been Tested?
A full QA will be performed on a staging environment