feat: active storage: make non-aws users happy #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @namehorn, Thanks for your PR! I merge this one and we will add the support of the new env var into https://github.com/getlago/lago/blob/main/docker-compose.yml and in our documentation. Cheers, |
vincent-pochet
approved these changes
Aug 1, 2022
|
Hi @jdenquin, are you down for some more merges regarding native GCS support & helm kubernetes integration? I have a few things lying around here. |
|
@namehorn can you join our slack community? getlago.com/slack But yes you're welcome to create some other PR around this! |
jdenquin
added a commit
that referenced
this pull request
Aug 1, 2022
This was referenced Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heyyyy Guys,
this PR makes S3 endpoints overwriteable.
https://edgeguides.rubyonrails.org/active_storage_overview.html#s3-service-amazon-s3-and-s3-compatible-apis