Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (gocardless): gocardless integration #600

Merged
merged 18 commits into from
Nov 17, 2022
Merged

feat (gocardless): gocardless integration #600

merged 18 commits into from
Nov 17, 2022

Conversation

lovrocolic
Copy link
Collaborator

@lovrocolic lovrocolic commented Nov 15, 2022 •
edited
Loading

Context

Add GoCardless Integration

Description

This is the feature branch for GoCardless integration. Main changes:

  • Add possibility to create customers in GCL
  • Create authorisation link that is sent in webhook in order to collect end-user payment details
  • Trigger payment in GCL
  • Listen to GCL webhooks and update invoice status accordingly

Previously reviewed PRS that are inside:
#595
#576
#575
#570
#568
#564
#557

This PR is already in main: #541

lovrocolic and others added 17 commits October 24, 2022 11:45
@lovrocolic
apply some gocardless configuration
c05f441
@lovrocolic @vincent-pochet
feat (gocardless): handle gocardless customers (#557)
34ecf8c 
* handle gocardless customers

* fix style offences

* fix rubocop issue

* add few small updates

* fix pronto issues

* fix regression issue

* update app/services/customers/create_service.rb

Co-authored-by: Vincent Pochet <[email protected]>

* fix few PR comments

Co-authored-by: Vincent Pochet <[email protected]>
@lovrocolic
add few changes needed for FE
57827ac
@lovrocolic
rename mandate_id to provider_mandate_id
a3a1d4c
@lovrocolic
feat (gocardless): add source in current context (#564)
6fe05f3 
* add source in current context

* fix specs
@lovrocolic
feat(gocardless): implement gocardless payment flow (#570)
9c1a7be
@lovrocolic
feat (gocardless): generate checkout url with billing request flow (#568
97e8229 
)

* generate checkout url with billing request flow

* fix pronto issues

* apply few fixes

* fix pronto issues
@lovrocolic
Merge branch 'main' into feature/gocardless-integration
0d970a0
@lovrocolic
feat (gocardless): fetch mandate before payment (#575)
9fe4bc4 
* fetch mandate before payment

* fix style issue

* fect (gocardless): handle incoming webhooks (#576)

* handle incoming webhooks

* add webhooks specs

* fix style issue
@lovrocolic
Merge branch 'main' into feature/gocardless-integration
f278439
@lovrocolic
use env variable for lago proxy
8f0fe21
@lovrocolic
Merge branch 'main' into feature/gocardless-integration
6d53b2a 
# Conflicts:
#	app/serializers/v1/customer_serializer.rb
@lovrocolic
change error code for unsuccessful fetch of gcl access token
b083ea1
@lovrocolic
return result object in service method
a50fc4e
@lovrocolic
handle resubmission request payment status
589df2d
@lovrocolic
Merge branch 'main' into feature/gocardless-integration
e77d8a0
@lovrocolic
fix (gocardless): fix calling invoice without its instance var (#595)
88e9e97 
* fix calling invoice without instance var

* apply few improvements

* fix pronto issue
@lovrocolic lovrocolic merged commit 469f521 into main Nov 17, 2022
@lovrocolic lovrocolic deleted the feature/gocardless-integration branch November 17, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdenquin jdenquin jdenquin approved these changes

@vincent-pochet vincent-pochet Awaiting requested review from vincent-pochet

@rsempe rsempe Awaiting requested review from rsempe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lovrocolic @jdenquin