feat (gocardless): fetch mandate before payment #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdenquin
reviewed
Oct 31, 2022
vincent-pochet
approved these changes
Oct 31, 2022
* handle incoming webhooks * add webhooks specs * fix style issue
lovrocolic
added a commit
that referenced
this pull request
Nov 17, 2022
* apply some gocardless configuration * feat (gocardless): handle gocardless customers (#557) * handle gocardless customers * fix style offences * fix rubocop issue * add few small updates * fix pronto issues * fix regression issue * update app/services/customers/create_service.rb Co-authored-by: Vincent Pochet <[email protected]> * fix few PR comments Co-authored-by: Vincent Pochet <[email protected]> * add few changes needed for FE * rename mandate_id to provider_mandate_id * feat (gocardless): add source in current context (#564) * add source in current context * fix specs * feat(gocardless): implement gocardless payment flow (#570) * feat (gocardless): generate checkout url with billing request flow (#568) * generate checkout url with billing request flow * fix pronto issues * apply few fixes * fix pronto issues * feat (gocardless): fetch mandate before payment (#575) * fetch mandate before payment * fix style issue * fect (gocardless): handle incoming webhooks (#576) * handle incoming webhooks * add webhooks specs * fix style issue * use env variable for lago proxy * change error code for unsuccessful fetch of gcl access token * return result object in service method * handle resubmission request payment status * fix (gocardless): fix calling invoice without its instance var (#595) * fix calling invoice without instance var * apply few improvements * fix pronto issue Co-authored-by: Vincent Pochet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add few improvements related to gocardless feature
Description