Fix bug in volcano extension causing crash when volcano turned off #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…only This update fixes a problem where the simulation will crash in the volcano extension init subroutine on non-root threads if the volcano extension is turned off, such as in the transport tracer simulation. The fix moves the return if extension number is zero to directly after the call to retrieve extension number. This is the same handling as all other HEMCO extension initialization routines. Signed-off-by: Lizzie Lundgren <[email protected]>
4 tasks
|
Note I did not make an edit to the changelog since the bug came in with 14.2.0 alpha.16, in PR #221 in which I bracketed new code for printing to log in an amIRoot block. |
msulprizio
approved these changes
Jul 24, 2023
|
All GCClassic and GCHP integration tests for this PR have passed. I will now merge it into dev/3.7.0. |
yantosca
added
topic: HEMCO Extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Confirm you have reviewed the following documentation
Describe the update
This update fixes a problem where the simulation will crash in the volcano extension init subroutine on non-root threads if the volcano extension is turned off, such as in the transport tracer simulation. The fix moves the return if extension number is zero to directly after the call to retrieve extension number. This is the same handling as all other HEMCO extension initialization routines.
Expected changes
The model will not crash if the volcano extension is turned off.
Reference(s)
none
Related Github Issue(s)
geoschem/GCHP#331