Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print HEMCO verbose status and volcano extension on root thread only #221

Merged

Conversation

lizziel
Copy link
Contributor

@lizziel lizziel commented Jun 28, 2023

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Confirm you have reviewed the following documentation

Describe the update

The message "HEMCO verbose output is OFF" is printed by every thread by default. This leads to excessive prints in the log file when running with lots of cores, such as in CESM , GCHP, and GEOS. This PR limits the status message to root thread only.

Expected changes

Shorter log file.

Reference(s)

None.

Related Github Issue(s)

None. This bug is not present in any releases since it came in during 14.2.0 development.

@lizziel lizziel added the category: Bug Something isn't working label Jun 28, 2023
@lizziel lizziel added this to the 3.7.0 milestone Jun 28, 2023
@lizziel lizziel requested a review from yantosca June 28, 2023 19:53
@lizziel lizziel self-assigned this Jun 28, 2023
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple update to add an IF statement that prevents printout unless we are on the root core. Good to merge!

@lizziel lizziel changed the title Print HEMCO verbose status on root thread only Print HEMCO verbose status and volcano extension on root thread only Jun 30, 2023
@lizziel lizziel force-pushed the bugfix/print_HEMCO_verbose_status_on_root_thread_only branch from f714e28 to 640f907 Compare June 30, 2023 19:23
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a missing IF statement to turn off messages that would be printed to all cores. Good to merge.

@msulprizio msulprizio merged commit 4b379f6 into dev/3.7.0 Jul 13, 2023
1 check passed
@msulprizio msulprizio deleted the bugfix/print_HEMCO_verbose_status_on_root_thread_only branch July 13, 2023 18:34
@yantosca yantosca added topic: HEMCO Extensions Pertaining to HEMCO extensions category: Bug Fix Fixes a bug that was previously reported and removed category: Bug Something isn't working labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a bug that was previously reported topic: HEMCO Extensions Pertaining to HEMCO extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants