-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] Simplify turning off all emissions including extensions #249
Comments
msulprizio
added a commit
that referenced
this issue
Nov 28, 2023
The EMISSIONS logical switch in HEMCO_Config.rc currently only turns off base emissions and not the emission extensions. The emission extension data are bracketed by the logical so those data are not read in. However, because the extensions themselves are still on, they get called in HEMCO and result in the model crashing because the input data can't be found. This is now fixed by adding a check in subroutine ExtSwitch2Buffer (in hco_config_mod.F90) to see if EMISSIONS is set and using that to define a local logical DoEmis. In that same routine, if DoEmis is false then all emission extensions will be defined with Enabled = .FALSE. to avoid calling them during the run stage of HEMCO. Addresses #249. Signed-off-by: Melissa Sulprizio <[email protected]>
We can now close this issue as PR #250 has been merged into the "no-diff-to-benchmark" development stream. |
Related issue: geoschem/geos-chem#1420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Name and Institution (Required)
Name: Melissa Sulprizio
Institution: Harvard / GCST
New HEMCO feature or discussion
The EMISSIONS logical switch in HEMCO_Config.rc currently only turns off base emissions and not the emission extensions. The emission extension data are bracketed by the logical so those data are not read in. However, because the extensions themselves are still technically on, they get called in HEMCO and result in the model crashing because the input data can't be found.
We need a more elegant solution for disabling all emissions. This should involve moving the EMISSIONS logical outside of the base emissions (ExtNr=0) section:
It would also be a good idea to better separate the emissions and non-emissions data (chemistry input) - perhaps even splitting them off into a separate HEMCO_Config.rc file as is currently done for the met fields.
This should be considered when doing the general HEMCO_Config.rc overhaul as discussed in #102.
The text was updated successfully, but these errors were encountered: