Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Simplify turning off all emissions including extensions #249

Closed
msulprizio opened this issue Nov 28, 2023 · 2 comments · Fixed by #250
Closed

[FEATURE REQUEST] Simplify turning off all emissions including extensions #249

msulprizio opened this issue Nov 28, 2023 · 2 comments · Fixed by #250
Assignees
Labels
category: Feature Request New feature or request
Milestone

Comments

@msulprizio
Copy link
Contributor

Name and Institution (Required)

Name: Melissa Sulprizio
Institution: Harvard / GCST

New HEMCO feature or discussion

The EMISSIONS logical switch in HEMCO_Config.rc currently only turns off base emissions and not the emission extensions. The emission extension data are bracketed by the logical so those data are not read in. However, because the extensions themselves are still technically on, they get called in HEMCO and result in the model crashing because the input data can't be found.

We need a more elegant solution for disabling all emissions. This should involve moving the EMISSIONS logical outside of the base emissions (ExtNr=0) section:

# ExtNr ExtName                on/off  Species   Years avail.
0       Base                   : on    *
# ----- MAIN SWITCHES ---------------------------------------------------------
    --> EMISSIONS              :       true
    --> METEOROLOGY            :       true      # 1980-2021
    --> CHEMISTRY_INPUT        :       true

It would also be a good idea to better separate the emissions and non-emissions data (chemistry input) - perhaps even splitting them off into a separate HEMCO_Config.rc file as is currently done for the met fields.

This should be considered when doing the general HEMCO_Config.rc overhaul as discussed in #102.

@msulprizio msulprizio added the category: Feature Request New feature or request label Nov 28, 2023
@msulprizio msulprizio self-assigned this Nov 28, 2023
msulprizio added a commit that referenced this issue Nov 28, 2023
The EMISSIONS logical switch in HEMCO_Config.rc currently only turns off
base emissions and not the emission extensions. The emission extension data
are bracketed by the logical so those data are not read in. However, because
the extensions themselves are still on, they get called in HEMCO and result
in the model crashing because the input data can't be found.

This is now fixed by adding a check in subroutine ExtSwitch2Buffer (in
hco_config_mod.F90) to see if EMISSIONS is set and using that to define a
local logical DoEmis. In that same routine, if DoEmis is false then all
emission extensions will be defined with Enabled = .FALSE. to avoid calling
them during the run stage of HEMCO.

Addresses #249.

Signed-off-by: Melissa Sulprizio <[email protected]>
@msulprizio msulprizio added this to the 3.7.2 milestone Nov 28, 2023
@yantosca
Copy link
Contributor

We can now close this issue as PR #250 has been merged into the "no-diff-to-benchmark" development stream.

@lizziel
Copy link
Contributor

lizziel commented Dec 11, 2023

Related issue: geoschem/geos-chem#1420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants